Bug 122001 - Delete key is not transparently assigned to shortcut
Summary: Delete key is not transparently assigned to shortcut
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Customize-Dialog-Keyboard Shortcuts-Accelerators
  Show dependency treegraph
 
Reported: 2018-12-10 08:41 UTC by Heiko Tietze
Modified: 2021-02-23 10:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Delete Contents command in the Customize dialog in current master (108.35 KB, image/png)
2021-01-12 22:33 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2018-12-10 08:41:23 UTC
Customization of Del was requested on the ML [1]. The trick is to assign an action to "Delete Content" (thanks Piet for finding this) though it would be more transparent for the user when Del itself has a clear assignment in the first place (apparently to this command).

[1] http://document-foundation-mail-archive.969070.n3.nabble.com/Adding-keyboard-shortcut-tc4254134.html
Comment 1 Roman Kuznetsov 2018-12-21 21:39:23 UTC
Heiko, could you write your suggestion in detail?
Comment 2 Xisco Faulí 2019-01-22 16:35:39 UTC
(In reply to Roman Kuznetsov from comment #1)
> Heiko, could you write your suggestion in detail?

Hi Heiko,
Please elaborate it a bit more...
Moving to NEW...
Comment 3 Heiko Tietze 2019-01-22 17:44:43 UTC
We need an UNO command in order to allow customization. More info in the referenced post to the mailing list.
Comment 4 Gabor Kelemen (allotropia) 2021-01-12 22:33:55 UTC
Created attachment 168841 [details]
Delete Contents command in the Customize dialog in current master

This command exists, and it is assigned the Delete key on the generic application level since forever (okay, only checked LO 6.0.7 right now):

officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu:      <node oor:name=".uno:Delete" oor:op="replace">
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu-        <prop oor:name="Label" oor:type="xs:string">
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu-          <value xml:lang="en-US">Delete C~ontents...</value>
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu-        </prop>

It's just not very easy to find it, like finding any other command in our jungle of commands.

I think this is basically NAB.

Maybe a bit more documentation could be useful on the top right radio buttons in this dialog.
Comment 5 Heiko Tietze 2021-01-18 10:53:51 UTC
(In reply to Gabor Kelemen from comment #4)
> This command exists...

But the key is still hard-coded, or am I wrong? Guess the UNO command comes in addition.
Comment 6 NISZ LibreOffice Team 2021-02-23 10:33:57 UTC
(In reply to Heiko Tietze from comment #5)
> (In reply to Gabor Kelemen from comment #4)
> > This command exists...
> 
> But the key is still hard-coded, or am I wrong? Guess the UNO command comes
> in addition.

I think the uno:Delete command has the Delete key assigned to it via Accelerators.xcu:

https://opengrok.libreoffice.org/search?project=core&full=%22uno%3ADelete%22&defs=&refs=&path=officecfg&hist=&type=&xrd=&nn=1

So it's possible to change it in the Keyboard dialog, like OP asked on the Users ML.
Changing the global shortcut of Delete Contents to (just for an example) Shift+Ctrl+D and unassigning the existing Writer-level command of Shift+Ctrl+D works as expected.

This covers the editors, but not all dialogs, side bars (Gallery comes to mind) etc where it is explicitly handled by code. That was not asked for though, as far as I understand. 

All in all: feature wise -> NAB; but documentation (extended/normal tooltip) could be more detailed.

Also the option to switch between generic shortcuts and application-specific ones (selected by default) could be made more prominent after an upcoming redesign of the whole tab (bug #115527 - also see similar requests bug # 83548 and bug #66298). 

Currently the extended help says: "Displays shortcut keys that are common to all %PRODUCTNAME applications." [1]
while there is no default tooltip - setting something for that sounds actionable for the short term.

[1]
https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/accelconfigpage.ui?r=5143de38#164

Cheers
Gabor