Bug 122080 - Changing master slide template back and forth leads to broken result (comment 5)
Summary: Changing master slide template back and forth leads to broken result (comment 5)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 138656 157433 (view as bug list)
Depends on:
Blocks: Sidebar-Master-Slides Master-Slide
  Show dependency treegraph
 
Reported: 2018-12-13 16:42 UTC by Martin Sourada
Modified: 2023-11-13 21:34 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Example ODT saved in 3.3 after broken import (17.17 KB, application/vnd.oasis.opendocument.presentation)
2018-12-13 16:44 UTC, Martin Sourada
Details
behaviour in 6.2 (2.36 MB, video/mp4)
2019-05-31 13:00 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Sourada 2018-12-13 16:42:51 UTC
Description:
When applying/importing master slides via Master Slides side panel -> Available to use it often imports broken. Always reproducible when trying to import Pencil master page into empty presentation with *Czech UI language*. In 5.3 and 3.3 I reproduced it with English locale as well though… I reproduced it in Linux and Windows (both amd64)

Steps to Reproduce:
1. Open Impress with Czech UI (cs_CZ)
2. Create new empty presentation, without any template
3. Switch to Master Slides side panel
4. Select Pencil template

Actual Results:
The master slide is imported broken, currently with the pencil illustration being in a bright blue rectangle. See attachments for example.

Expected Results:
The newly imported master slide should look exactly like if new presentation from Pencil template was created.


Reproducible: Always


User Profile Reset: No



Additional Info:
Earliest I tried (needed to import the Pencil template):
LibreOffice 3.3.4 
OOO330m19 (Build:401)
tag libreoffice-3.3.4.1

Newest I tried:
Version: 6.2.0.0.beta1
Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18
CPU threads: 2; OS: Linux 3.10; UI render: default; VCL: gtk3; 
Locale: cs-CZ (cs_CZ.UTF-8); UI-Language: cs-CZ
Calc: threaded

Also reproduced in:
Version: 6.1.3.2
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU Threads: 2; OS: Linux 3.10; UI Render: default; VCL: gtk3; 
Flatpak
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group threaded

Version: 6.0.7.3
Build ID: dc89aa7a9eabfd848af146d5086077aeed2ae4a5
CPU Threads: 2; OS: Linux 3.10; UI Render: default; VCL: gtk2; 
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group

Version: 5.3.6.1
Build ID: 5.3.6.1-19.el7
CPU Threads: 2; OS Version: Linux 3.10; UI Render: default; VCL: gtk3; Layout Engine: new; 
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group
Comment 1 Martin Sourada 2018-12-13 16:44:54 UTC
Created attachment 147507 [details]
Example ODT saved in 3.3 after broken import
Comment 2 Martin Sourada 2018-12-13 16:49:33 UTC
Another interesting thing is, that in 6.2b1 the brokenness does not survive round trip (save-close-open)… And the one created in 3.3 is broken differently when opened by 5.3 and when opened in 6.1. Need to try in other versions as well.
Comment 3 Durgapriyanka 2018-12-13 18:47:16 UTC
Thank you for reporting the bug. I can not reproduce the bug in

Version: 6.1.3.2
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 2; OS: Windows 6.1; UI render: default; 
Locale: en-US (en_US); Calc: group threaded
Comment 4 Martin Sourada 2018-12-13 21:16:21 UTC
Yes, I didn't fully reproduce it with en_US UI locale :-/

Here's a short video of the bug:
https://drive.google.com/open?id=1KE69CBLtR1RJDX2D55vBgU6gGjrNPgJe
Comment 5 Martin Sourada 2018-12-13 21:39:12 UTC
I've just figured easier to reproduce steps:

1. Open Impress
2. Create empty presentation
3. Switch to Pencil Master Slide via Master Slides in Sidebar
4. Switch to Vivid via Master Slides in Sidebar
5. Repeat steps 3. and 4 several times

Result:
Slide gradually changes with each switch (most noticeable is font-size change in Title style in both Vivid and Pencil and background change in Vivid).

Reproduced in:
Version: 6.1.3.2
Build ID: 86daf60bf00efa86ad547e59e09d6bb77c699acb
CPU threads: 2; OS: Linux 3.10; UI render: default; VCL: gtk3; 
Flatpak
Locale: en-US (en_US); Calc: group threaded

and

Version: 6.0.6.2 (x64)
Build ID: 0c292870b25a325b5ed35f6b45599d2ea4458e77
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: en-US (cs_CZ); Calc: CL
Comment 6 Buovjaga 2019-01-25 13:14:02 UTC
(In reply to Martin Sourada from comment #5)
> I've just figured easier to reproduce steps:
> 
> 1. Open Impress
> 2. Create empty presentation
> 3. Switch to Pencil Master Slide via Master Slides in Sidebar
> 4. Switch to Vivid via Master Slides in Sidebar
> 5. Repeat steps 3. and 4 several times
> 
> Result:
> Slide gradually changes with each switch (most noticeable is font-size
> change in Title style in both Vivid and Pencil and background change in
> Vivid).

Reproduced.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: bb30e9e591d5f9f913b3cd8fbaa3c5e412b509bd
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 23 January 2019
Comment 7 Stéphane Guillou (stragu) 2019-05-31 12:59:43 UTC
Very similar results in the 6.2 branch too.

In my case, most templates get mangled when I apply them, and some of them show blue rectangle, the first time I apply them for some, sometimes the second time for others... (see for example Piano, Vivid and Lights in attached video).

System details:

Version: 6.2.4.2
Build ID: 1:6.2.4-0ubuntu0.18.04.1~lo1
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-GB
Calc: threaded
Comment 8 Stéphane Guillou (stragu) 2019-05-31 13:00:42 UTC
Created attachment 151808 [details]
behaviour in 6.2
Comment 9 Stéphane Guillou (stragu) 2019-06-16 05:41:18 UTC Comment hidden (obsolete)
Comment 10 Stéphane Guillou (stragu) 2019-06-16 05:42:45 UTC
Sorry! Wrong bug!!

Still exact same issue as I described in Comment 7.

Sorry, got my tabs confused.
Comment 11 Stéphane Guillou (stragu) 2019-10-22 13:25:50 UTC
Still the same issue in current dev:

Version: 6.4.0.0.alpha1
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 12 Stéphane Guillou (stragu) 2020-05-11 12:07:14 UTC
Still reproducible in current dev:

Version: 7.0.0.0.alpha1
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 13 BogdanB 2020-05-11 13:15:31 UTC
I tested on Linux on x11, the same thing. I thought it was a GTK problem.

Version: 6.4.3.2
Build ID: libreoffice-6.4.3.2-snap1
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: x11; 
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded
Comment 14 Stéphane Guillou (stragu) 2020-05-21 05:40:25 UTC
I tested on Windows 10 too, for good measure, and can confirm the same behaviour: most templates will look different, usually with blue rectangles, as they are applied. All template previews change as they are applied the first time.

Version: 7.0.0.0.alpha1 (x64)
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; 
Locale: en-AU (en_AU); UI: en-US
Calc: threaded
Comment 15 Stéphane Guillou (stragu) 2021-05-29 11:32:21 UTC
Still reproducible in 7.2 alpha1, including with the brand new templates.

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: a02d9e8de07de4ab9f586f82aed7a2e0413520cd
CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-05-25_05:42:18
Calc: threaded
Comment 16 Stéphane Guillou (stragu) 2022-09-12 15:57:25 UTC
*** Bug 138656 has been marked as a duplicate of this bug. ***
Comment 17 Rizal Muttaqin 2022-09-12 21:49:18 UTC
(In reply to stragu from comment #8)
> Created attachment 151808 [details]
> behaviour in 6.2

I can not open the file in Firefox 104.0: Video can't be played because the file sis corrupt. Using Chrome also throw me nothing. May be we can use my attachment from tdf#138656:

attachment 167823 [details]
Comment 18 Buovjaga 2022-09-13 05:58:36 UTC
(In reply to Rizal Muttaqin from comment #17)
> (In reply to stragu from comment #8)
> > Created attachment 151808 [details]
> > behaviour in 6.2
> 
> I can not open the file in Firefox 104.0: Video can't be played because the
> file sis corrupt. Using Chrome also throw me nothing. May be we can use my
> attachment from tdf#138656:
> 
> attachment 167823 [details]

You can always Ctrl-S to save the video and play with VLC.
Comment 19 raal 2023-09-25 17:25:22 UTC
*** Bug 157433 has been marked as a duplicate of this bug. ***
Comment 20 Stéphane Guillou (stragu) 2023-11-13 15:24:18 UTC
We have been tracking several issues here.

Issue (1)
(In reply to Martin Sourada from comment #0)
[...]
> The master slide is imported broken, currently with the pencil illustration
> being in a bright blue rectangle. See attachments for example.
Reproduced _with UI-Language: cs-CZ but not with en-US_ in LO 6.0.0.3. However, not reproduced with LO 7.6.3.1 in Czech.
-> "works for me".

(In reply to Martin Sourada from comment #5)
> Slide gradually changes with each switch (most noticeable is font-size
> change in Title style in both Vivid and Pencil and background change in
> Vivid).
Issue (2):
Font size change: could also be seen with e.g. Midnightblue template. Reproduced in 6.3.6.2, not reproduced anymore in 7.0.6.2. -> works for me
Issue (3):
Vivid template background changing to stock blue: reproduced in 7.4.7.2, not reproduced in 7.5.8.2 -> works for me

(In reply to Stéphane Guillou (stragu) from comment #7) 
> In my case, most templates get mangled when I apply them
I think this is for the most part an impression I had because the previews update to whatever layout is used by the slide.
> some of them
> show blue rectangle, the first time I apply them for some, sometimes the
> second time for others... (see for example Piano, Vivid and Lights in
> attached video).
Issue (4):
Reproduced in 6.2.0.3 for Piano, Vivid, Lights, Portfolio, Forestbird, Lush Green, Blueprint Plans, Nature Illustration.
Issue got worse with a bunch of other templates, which can be see in e.g. version 7.1 or 7.3.
Still reproduced in recent trunk build for some templates:
* Candy
* Freshes
* Midnightblue
* Blueprint Plans
* Nature Illustration
-> issue still current.

Because this light blue colour change is a regression for Midnightblue, I wanted to check when it started.
Bibisected with linux-64-7.0 repo to build commit [a2599bf44bb9b7ba90f34601f2d48991beb8a5b4] which points to core commit:
commit 7f10ae03e161545d10cca50030461b1ae530302e
author	andreas kainz 	Tue Apr 28 13:48:49 2020 +0200
committer	andreas_kainz 	Tue Apr 28 17:29:48 2020 +0200
tdf#132138 Update Midnightblue impress template
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93061

And because e.g. Portfolio and Forestbird got fixed along the way, here are the commits that fixed them:
* Forestbird fixed in 7.5 by Laurent Balland with f4adc07f4ab5f44b4bf60ae01e508d7c29682790 - "tdf#135060 Modify Forestbird template". Thanks Laurent!
* Portflio fixed in 7.0 by Andreas Kainz with 1498fc92527785eb47eb1bb30d957150dc513dfb - "tdf#132138 Update Portfolio impress template"

Andreas and Laurent, I assume the best way forward would be to open new reports about each individual templates that still have issues, wouldn't you agree?
Comment 21 Stéphane Guillou (stragu) 2023-11-13 15:34:45 UTC
(In reply to Stéphane Guillou (stragu) from comment #20)
> * Portflio fixed in 7.0 by Andreas Kainz
(and thanks Andreas too :)
Comment 22 Laurent Balland 2023-11-13 16:52:50 UTC
(In reply to Stéphane Guillou (stragu) from comment #20)
> Andreas and Laurent, I assume the best way forward would be to open new
> reports about each individual templates that still have issues, wouldn't you
> agree?

Actually with one report containing a mix of fixed and not (still) fixed bugs is really difficult. I would appreciate one report per bug.

Currently, I'm working on Grey Elegant template in bug 158022. Bug 158017 is more about Freshes template. May be one bug report per template would be enough?
Comment 23 Stéphane Guillou (stragu) 2023-11-13 20:40:24 UTC
(In reply to Laurent Balland from comment #22)
> (In reply to Stéphane Guillou (stragu) from comment #20)
> > Andreas and Laurent, I assume the best way forward would be to open new
> > reports about each individual templates that still have issues, wouldn't you
> > agree?
> 
> Actually with one report containing a mix of fixed and not (still) fixed
> bugs is really difficult. I would appreciate one report per bug.
> 
> Currently, I'm working on Grey Elegant template in bug 158022. Bug 158017 is
> more about Freshes template. May be one bug report per template would be
> enough?

OK, let's do that. Closing as WFM for issues (1), (2) and (3). I'll link new reports to this one.