Bug 122241 - Theme does not affect menu bar in GTK3
Summary: Theme does not affect menu bar in GTK3
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.1 rc
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.1
Keywords:
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2018-12-21 10:03 UTC by Kriton Kyrimis
Modified: 2019-01-27 22:00 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Theme is gone after reopening the component (2.41 MB, video/mp4)
2019-01-23 12:03 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kriton Kyrimis 2018-12-21 10:03:55 UTC
Up until version 6.1, the theme background would be also painted on the menu bar, when using the KDE interface. In 6.2, this is no longer the case, and the menu bar has the default background color.

If there is some limitation in GTK, that prevents having a background in the menu bar, I think that it would be better to have that limitation removed, instead of removing the functionality from the KDE interface.
Comment 1 Xisco Faulí 2019-01-21 14:48:44 UTC
Also reproduced in gtk3. not reproduced in gtk2/kde4

Version: 6.3.0.0.alpha0+
Build ID: 3fa4674615b747e219afe5bf0a9b689df3840439
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc:
Comment 2 Caolán McNamara 2019-01-22 11:22:18 UTC
I can try the gtk css stuff to hack this into the native gtk3 menubar
Comment 3 Commit Notification 2019-01-22 17:24:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/46efac592b76d32152353466120eea2c9800858f%5E%21

Resolves: tdf#122241 support persona header in native gtk3 menubar

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2019-01-22 17:31:06 UTC
because both gtk and kde were mentioned in this bug, but the implementations don't have anything to do with eachother this is really two separate bugs/feature requests. I'll strip mention of GTK and leave this the remainder as a KDE bug I guess
Comment 5 Xisco Faulí 2019-01-23 12:00:45 UTC
Since we have a commit fixing it for GTK3, let's use this one for GTK3. I'll create a new one for KDE5
Comment 6 Xisco Faulí 2019-01-23 12:03:54 UTC
Created attachment 148550 [details]
Theme is gone after reopening the component

Hi Caolán,
I see the menubar is decorated in

Version: 6.3.0.0.alpha0+
Build ID: 8f7c35072a6bbb33f6582c8c9a37a275c8d3cb14
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

however, it's gone if I close the component and I open it again
Comment 7 Caolán McNamara 2019-01-23 12:49:41 UTC
small tweak required for additional menubars after the first one apparently
Comment 8 Commit Notification 2019-01-23 17:03:17 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/45c1056fb4d05b0a8efe0b23ae21e67e68393d9c%5E%21

Related: tdf#122241 improve applying persona for additional menubars

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2019-01-23 17:09:58 UTC
that seems to work better, back-port updated
Comment 10 Commit Notification 2019-01-25 08:29:05 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/e586d6eca6686ab987195913dad27d89e65d3d5b%5E%21

Resolves: tdf#122241 support persona header in native gtk3 menubar

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2019-01-25 10:00:36 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: a6358f1c1b8f981345061b0cbb708df707a5b7b8
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, thanks for fixing this!