Bug 122259 - LO: Some icons have different height for icon style = Elementary (SVG)
Summary: LO: Some icons have different height for icon style = Elementary (SVG)
Status: CLOSED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.0.beta1+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0
Keywords:
Depends on:
Blocks: Icon-Themes-Code-SVG
  Show dependency treegraph
 
Reported: 2018-12-21 14:01 UTC by Vera Blagoveschenskaya
Modified: 2021-05-26 10:32 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
elementary-1 (72.61 KB, image/png)
2018-12-21 14:01 UTC, Vera Blagoveschenskaya
Details
elementary-2 (33.08 KB, image/png)
2018-12-21 14:01 UTC, Vera Blagoveschenskaya
Details
elementary-3 (27.53 KB, image/png)
2018-12-21 14:15 UTC, Vera Blagoveschenskaya
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vera Blagoveschenskaya 2018-12-21 14:01:11 UTC
Description:
Some icons have different height for icon style = Elementary (SVG)

Steps to Reproduce:
1. Tools -> Options, Libreoffice -> View
2. Select icon style = Elementary (SVG)
3. Look at icons in the toolbars

Actual Results:
There are some difference in icons height. Look at the screens

DO NOT reproduced for icon style = Elementary (not SVG)



Expected Results:
The same height 


Reproducible: Always


User Profile Reset: No



Additional Info:
Reproduced for 

Version: 6.2.0.1
Build ID: 0412ee99e862f384c1106d0841a950c4cfaa9df1
CPU threads: 1; OS: Linux 4.14; UI render: default; VCL: kde5; 
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

Version: 6.2.0.1
Build ID: 0412ee99e862f384c1106d0841a950c4cfaa9df1
CPU threads: 1; OS: Linux 4.14; UI render: default; VCL: gtk3; 
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Vera Blagoveschenskaya 2018-12-21 14:01:43 UTC
Created attachment 147745 [details]
elementary-1
Comment 2 Vera Blagoveschenskaya 2018-12-21 14:01:58 UTC
Created attachment 147746 [details]
elementary-2
Comment 3 Vera Blagoveschenskaya 2018-12-21 14:15:16 UTC
Created attachment 147749 [details]
elementary-3
Comment 4 Durgapriyanka 2018-12-21 18:39:03 UTC
Thank you for reporting the bug. I can confirm the bug with Impress and Formula in

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 5 Regina Henschel 2019-01-17 21:25:13 UTC
I guess, it is the same problem as I have noticed with the markers.svg, bug 121130. The png-icons, which are generated from the svg-files have wrong size. They are 1 pixel too wide and 1 pixel too high. So the large command icons become 25x25, where they should be 24x24 (for me with 100% scaling). The generated png-icons are stored in the cache folder.

If a command, does not have a svg-file yet, in your example the lc_zoommode, then an ersatz is used. In this case the lc_zoomoptimal.png from Colibre and that is a 24x24 png-icon. So the icons have different size.

The images, which belong to the toolbars, are in subfolder 'cmd' from the icon-themes.

That is a guess, but perhaps someone can prove it. If I'm correct, then the problem is not in the icons themselves but in the conversion to png.
Comment 6 Heiko Tietze 2019-01-18 07:51:19 UTC
Tomaz, any idea about the cause?
Comment 7 Commit Notification 2019-01-25 10:56:36 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/5cdb0821d2b59145cf83ea3652a5df72a6a3c8c8%5E%21

tdf#122259 resolve image link as both - png and svg

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Vera Blagoveschenskaya 2019-01-28 06:23:08 UTC
Still reproduced (for example, look at the icons from Comment2, Comment3)

Version: 6.3.0.0.alpha0+
Build ID: 6e80862ee6851b75fc7fa628156400bb044391ee
CPU threads: 4; OS: Linux 4.14; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-01-22_16:54:24
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 9 Rizal Muttaqin 2019-04-24 18:38:44 UTC
This bug is highly related to defected SVG support in LibO, so from designer point of view, I couldn't give much further improvement. The only way is just stick with PNG version instead.
Comment 10 QA Administrators 2021-04-24 04:09:47 UTC Comment hidden (obsolete)
Comment 11 Vera Blagoveschenskaya 2021-05-26 10:32:38 UTC
Hello all,
I've checked this bug for

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: a02d9e8de07de4ab9f586f82aed7a2e0413520cd
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: kf5 (cairo+xcb)
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-05-25_05:42:18
Calc: threaded

Problem is not actual anymore.