Download it now!
Bug 122478 - UI: dialog page Area (for example Page Style), choice Bitmap: option "Scale" is active with style "Tiled"
Summary: UI: dialog page Area (for example Page Style), choice Bitmap: option "Scale" ...
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.1.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-01-04 11:54 UTC by Cor Nouws
Modified: 2019-01-21 10:43 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Old area dialog in LibO 5.2 (83.37 KB, image/gif)
2019-01-21 09:42 UTC, Katarina Behrens (Inactive)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2019-01-04 11:54:18 UTC
Writer document
dialog Format Page, page Area, Bitmap
  > for style "Tiled" the option "Scale" is active
those are orthogonal.

Versie: 6.1.0.1
Build ID: 378e26bd4f22a135cef5fa17afd5d4171d8da21a
CPU-threads: 4; Besturingssysteem: Linux 4.15; UI-render: standaard; VCL: gtk2; 
Locale: nl-NL (nl_NL.UTF-8); Calc: group threaded
Comment 1 Cor Nouws 2019-01-04 11:55:24 UTC
was OK in 6.0.x > regression
Comment 2 Durgapriyanka 2019-01-04 22:49:51 UTC
Thank you for reporting the bug. I can confirm this with

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 3 Xisco Faulí 2019-01-17 17:05:56 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3a30799e377004f77ddcf5c1d6b62ca3e62c0905

author	Katarina Behrens <Katarina.Behrens@cib.de>	2018-03-31 18:46:38 +0200
committer	Katarina Behrens <Katarina.Behrens@cib.de>	2018-04-08 11:05:16 +0200
commit	3a30799e377004f77ddcf5c1d6b62ca3e62c0905 (patch)
tree	8cf2970af6ead558f2f2438961228991418d28f5
parent	d2c8766a5e827e53f8f34893ff3d82a0df252f30 (diff)
Show preview correctly for relative size

Bisected with: bibisect-linux64-6.1

Adding Cc: to Katarina Behrens
Comment 4 Xisco Faulí 2019-01-17 17:09:33 UTC
@bubli, since 3a30799e377004f77ddcf5c1d6b62ca3e62c0905 doesn't have any reference to a bug, do you remember why you did it? should we just revert it ?
Comment 5 Katarina Behrens (Inactive) 2019-01-19 16:21:34 UTC
(In reply to Xisco Faulí from comment #4)
> @bubli, since 3a30799e377004f77ddcf5c1d6b62ca3e62c0905 doesn't have any
> reference to a bug, do you remember why you did it? should we just revert it
> ?

This was part of some larger refactoring, with handful of bugs such as bug 104411, bug 105194, bug 111719, bug 104658 and maybe some others, all related and interconnected and impossible to separate.

However I disagree this would be a bug. Why would tiling with a scaled bitmap not be possible? It used be possible all the way from OOo until 5.2. In 5.3 the area tab GSoC redesign happened, so if it "worked" in 6.0 (and 5.4 and 5.3), then it was an implementation error.
Comment 6 Cor Nouws 2019-01-20 21:04:23 UTC
Hi Bubli,

(In reply to Katarina Behrens (CIB) from comment #5)

> However I disagree this would be a bug. Why would tiling with a scaled
> bitmap not be possible? 
Ah.. indeed. Initially scaling sets it to 100%, and I interpreted that as full page width/height. Odd.
So not a bug. Sorry,

> It used be possible all the way from OOo until 5.2.
In OOo and up to our much improved version, I don't see the combination tile and scale.
Comment 7 Katarina Behrens (Inactive) 2019-01-21 09:42:47 UTC
Created attachment 148467 [details]
Old area dialog in  LibO 5.2

> > It used be possible all the way from OOo until 5.2.
> In OOo and up to our much improved version, I don't see the combination tile
> and scale.

I do, see attached screenshot. But maybe I misunderstood or it used to misbehave since day 1. Bitmap fill is hard :(
Comment 8 Xisco Faulí 2019-01-21 10:43:20 UTC
(In reply to Katarina Behrens (CIB) from comment #7)
> Created attachment 148467 [details]
> Old area dialog in  LibO 5.2
> 
> > > It used be possible all the way from OOo until 5.2.
> > In OOo and up to our much improved version, I don't see the combination tile
> > and scale.
> 
> I do, see attached screenshot. But maybe I misunderstood or it used to
> misbehave since day 1. Bitmap fill is hard :(

I tried in LibreOffice 3.3 but I don't see the bitmap option. In LibreOffice 5.2 I see the option Relative can be toggled with Tile, allowing us to use percentages or measures units