Bug Hunting Session
Bug 122593 - UI: Focus off. Not able to enter the style name immediately after style creating
Summary: UI: Focus off. Not able to enter the style name immediately after style creating
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.2.0.4 release
Hardware: All Windows (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2019-01-09 09:48 UTC by Telesto
Modified: 2019-01-27 20:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (2.91 KB, text/plain)
2019-01-27 20:23 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2019-01-09 09:48:19 UTC
Description:
UI: Focus off. Not able to enter the style name immediately after style creating

Steps to Reproduce:
1. Open Calc
2. Sidebar -> Styles
3. Right Click -> New Cell style
4. Name field is selected, but when typing nothing happens (working fine for Writer)

Actual Results:
Key presses have no effect on the name field

Expected Results:
Should be working


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 6.3.0.0.alpha0+
Build ID: 6e5c4001c7b5cab2b2cc6419072acbe5fa7cb04a
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

but not in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL
Comment 1 Cor Nouws 2019-01-09 11:13:10 UTC
(In reply to Telesto from comment #0)
> 4. Name field is selected, but when typing nothing happens (working fine for
> Writer)
For me, it is selected but also the pages Tab has the focus, so tabbing once really brings the focus in the name field.
In Writer, I have to hit Tab three times to get the focus in the Name field..
(and the dialog doesn't open automatically with page Manage on top).

similar in Version: 6.3.0.0.alpha0+
Build ID: 3bf82348bc73797fec61997dc4268a322299b3ff
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-01-06_08:29:45
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded

and 620.1
Comment 2 Cor Nouws 2019-01-09 11:14:11 UTC
(In reply to Cor Nouws from comment #1)
> For me, it is selected but also the pages Tab has the focus, so tabbing once
> really brings the focus in the name field.

Is that what you see too?
In any case, I confirm this :)
Comment 3 Telesto 2019-01-09 11:24:35 UTC
(In reply to Cor Nouws from comment #2)
> (In reply to Cor Nouws from comment #1)
> > For me, it is selected but also the pages Tab has the focus, so tabbing once
> > really brings the focus in the name field.
> 
> Is that what you see too?
> In any case, I confirm this :)

Yes, I agree on that. The organizer tab is focused & the name field selected. One tab moves the focus the the name fied.

I recall something about remembering the last tab used, which also applies - silly enough - when creating a New Style.. There might be a bug report or it has been dropped; i don't remember anymore..
Comment 4 Cor Nouws 2019-01-09 12:14:15 UTC
(In reply to Telesto from comment #3)

> I recall something about remembering the last tab used, which also applies -
> silly enough - when creating a New Style.. There might be a bug report or it
> has been dropped; i don't remember anymore..

see bug #122600
Comment 5 Telesto 2019-01-27 20:23:45 UTC
Created attachment 148694 [details]
Bibisect log

author	Katarina Behrens <Katarina.Behrens@cib.de>	2016-01-19 23:07:47 +0100
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2016-01-21 14:40:09 +0000
commit	39471da6e4d016c52c6cdf6553d7418416a160f4 (patch)
tree	285280e63b96fcf2066f1c56249a7fc0326c16ba
parent	e7eca35148204d094dcdb7d8b3e4ec6c9d454159 (diff)
tdf#95587: Make rectangle control within tab pages work again
Since commit 74407aef94b6d8dfdd6, tab pages|controls are
considered to be container widgets (thus, search for the nearest
non-layout parent will never find a tab page parent, breaking
rectangle control in many dialogs). I've no idea how many
other functions' behaviour this changes in an unexpected way,
so I've reverted that bit.

That however means implementing slightly different approach to
tdf#92630 in dialogs (for a tab dialog, find current tab page
and go through its children)

https://cgit.freedesktop.org/libreoffice/core/commit/?id=39471da6e4d016c52c6cdf6553d7418416a160f4
Comment 6 Telesto 2019-01-27 20:24:35 UTC Comment hidden (obsolete)
Comment 7 Telesto 2019-01-27 20:25:10 UTC Comment hidden (obsolete)