Bug 122616 - New Print dialog does not follow HIG capitalization rules
Summary: New Print dialog does not follow HIG capitalization rules
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: David Sass
URL:
Whiteboard: target:6.3.0
Keywords: difficultyBeginner, easyHack, implementationError, skillDesign, topicUI
Depends on:
Blocks: Print-Dialog
  Show dependency treegraph
 
Reported: 2019-01-09 21:27 UTC by Adolfo Jayme Barrientos
Modified: 2019-01-21 06:29 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adolfo Jayme Barrientos 2019-01-09 21:27:44 UTC
The Print dialog makes excessive use of title case in things that do not warrant its use; namely, dropdown and spin box labels (cf. attachment 148165 [details]).

See https://developer.gnome.org/hig-book/unstable/design-text-labels.html.en#layout-capitalization for guidance.

This is important to ensure proper style and avoiding sending wrong translatable strings to Pootle.
Comment 1 David Sass 2019-01-10 11:52:52 UTC
(In reply to Adolfo Jayme from comment #0)
> The Print dialog makes excessive use of title case in things that do not
> warrant its use; namely, dropdown and spin box labels 

Can you elaborate which options have this mistake?
Comment 2 Gabor Kelemen (allotropia) 2019-01-10 11:57:18 UTC
See the attachment in the first comment: there are the Number of Copies ; Paper Sides ; Paper Size ; Print in Reverse Order. All of these should have a capital letter at the beginning.
The Range and Copies and the Page Layout section titles are fine.
Comment 3 Commit Notification 2019-01-21 06:28:53 UTC
Sass Dávid committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2b34be5be176e6080f0a39294bf09c6d6183f4b5%5E%21

tdf#122616 UI Enhancement: Print dialog texts changed as requested in comments

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.