Bug 122702 - Dense bar charts pushes together the X axis labels
Summary: Dense bar charts pushes together the X axis labels
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:xls, regression
Depends on:
Blocks:
 
Reported: 2019-01-14 10:49 UTC by Gabor Kelemen (allotropia)
Modified: 2019-01-24 11:09 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the problem in Excel and Calc 6.3 (129.63 KB, image/png)
2019-01-14 10:49 UTC, Gabor Kelemen (allotropia)
Details
The document in 6.2 (81.42 KB, image/png)
2019-01-14 10:54 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the *.xls file in LO Master (141.69 KB, image/png)
2019-01-23 15:35 UTC, Balázs Varga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2019-01-14 10:49:56 UTC
Created attachment 148303 [details]
Screenshot of the problem in Excel and Calc 6.3

This is probably a recent regression.

See attachment #148283 [details] in current Calc and Excel.
The Tall Chart has long X axis labels rotated counterclockwise in Excel.
In Calc the chart area is taller and the axis labels are cramped together in a small area.

Version: 6.3.0.0.alpha0+
Build ID: 17dd2662ccfa9d04efbea74e5d7548db5b2126d4
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc:
Comment 1 Gabor Kelemen (allotropia) 2019-01-14 10:54:25 UTC
Created attachment 148304 [details]
The document in 6.2

Version: 6.2.0.0.beta1+
Build ID: e45c30858dec1dd705b9144fab981a3c8819ba96
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc:
Comment 2 raal 2019-01-14 14:51:13 UTC
I'll bisect it.
Comment 3 raal 2019-01-14 15:03:00 UTC
This seems to have begun at the below commit.
Adding Cc: to Balazs Varga ; Could you possibly take a look at this one?
Thanks
 74c7873c04833c943321f335ee67226fae5e826c is the first bad commit
commit 74c7873c04833c943321f335ee67226fae5e826c
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Dec 18 15:31:21 2018 +0100

    source f8d6de19181d749d7c2b345ce7084c0c07fa3eab

author	Balazs Varga <balazs.varga991@gmail.com>	2018-12-14 14:38:49 +0100
committer	Bartosz Kosiorek <gang65@poczta.onet.pl>	2018-12-18 11:04:40 +0100
commit f8d6de19181d749d7c2b345ce7084c0c07fa3eab (patch)
tree 3e3ce690b0ddffc46f2372f91542982130dd06e9
parent 574678cf92d50abf456ebbb56b9ea6cc5ca5ecf6 (diff)
tdf#108021 Chart: Fix text break of column chart X axis
Comment 4 Balázs Varga 2019-01-14 15:36:18 UTC
(In reply to raal from comment #3)
> This seems to have begun at the below commit.
> Adding Cc: to Balazs Varga ; Could you possibly take a look at this one?
> Thanks

Of course, sorry for that.

I already work on the second part of tdf#108021 bug. (https://gerrit.libreoffice.org/#/c/65937/) But unfortunately, even with this patch, it is far from the good working. Until, I figure out how can I solve this tdf#108021 bug better (without causing any regression), I will revert that patch.
Comment 5 Balázs Varga 2019-01-23 15:06:10 UTC
With this patch the regression probably fixed.

Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/40ffaa4f23fe59f979222facf1688d25c60651b6%5E%21

Related: tdf#108021 Fix text break of X axis labels

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Balázs Varga 2019-01-23 15:35:22 UTC
Created attachment 148563 [details]
Screenshot of the *.xls file in LO Master
Comment 7 Xisco Faulí 2019-01-24 11:09:02 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: 0d46fb02f3f19d11db40b6c5335d78a3894502d7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Balazs Varga, thanks for fixing this!