Bug 122797 - Comments from Calc can not be deleted if the comment doesnt have text in it
Summary: Comments from Calc can not be deleted if the comment doesnt have text in it
Status: RESOLVED DUPLICATE of bug 106000
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
5.0.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: List-Combobox-RenderContext-regressions
  Show dependency tree / graph
 
Reported: 2019-01-18 06:28 UTC by BogdanB
Modified: 2019-01-23 23:17 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
insert-comment (26.23 KB, image/png)
2019-01-18 08:11 UTC, Vera Blagoveschenskaya 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BogdanB 2019-01-18 06:28:25 UTC 
Description:
if we make a comment in a cell a write nothing to the comment, the comment is created, a red dot is there, but no menu for delete the comment.

The only option to delete the comment is to make a new comment with content and then to delete comment.

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 62ce65fe042543e7aeaf83bf66f8c2357ff902c6
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-17_02:33:10
Locale: ro-RO (ro_RO); UI-Language: en-US
Calc: threaded

Steps to Reproduce:
1. See the description, is very simple with a new file
2.
3.

Actual Results:
Comments can not be deleted if commens have no text.

Expected Results:
A comment with no text it is not saved, like in Writer.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+ (x64)
Build ID: 62ce65fe042543e7aeaf83bf66f8c2357ff902c6
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-01-17_02:33:10
Locale: ro-RO (ro_RO); UI-Language: en-US
Calc: threaded
Comment 1 Vera Blagoveschenskaya 2019-01-18 08:08:57 UTC 
Confirmed from my side

Version: 6.3.0.0.alpha0+
Build ID: 86501f577638b44042c35e601d13651992b64fd5
CPU threads: 4; OS: Linux 4.14; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-01-16_17:35:02
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

For empty comment there is only possibility to insert comment in the context menu - see screenshot.
'Workaround' how to delete comment - you can insert some comment, and delete comment after it.
Comment 2 Vera Blagoveschenskaya 2019-01-18 08:11:54 UTC 
Created attachment 148416 [details]
insert-comment
Comment 3 raal 2019-01-18 08:33:38 UTC 
empty comment disappear after save document. In previous versions empty comment was deleted immediatelly.
This was changed in this commit:
 db76ebae674812c4c3dffafc2d02201a67dd15a7 is the first bad commit
commit db76ebae674812c4c3dffafc2d02201a67dd15a7
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Wed Jun 3 14:29:56 2015 -0500

    source dca01def7885ad69cf66edd75cf8207a5adb64f9
author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2015-05-07 14:18:37 +0900
committer	Jan Holesovsky <kendy@collabora.com>	2015-05-07 09:57:50 +0200
commit dca01def7885ad69cf66edd75cf8207a5adb64f9 (patch)
tree f3b43717ab058b677c68614bcb2953beb7c7d1a0
parent 7a11ec1992bf877f42edce8d1d930c5b00bd3d48 (diff)
refactor ListBox/ComboBox to use RenderContext


Adding Cc: to Tomaž Vajngerl; Could you possibly take a look at this one? Thanks
Comment 4 Xisco Faulí 2019-01-23 23:17:06 UTC 
It seems like a duplicate of bug 106000

*** This bug has been marked as a duplicate of bug 106000 ***