Bug 122880 - GTK3: Auto Caption dialog doesn't show the list of elements
Summary: GTK3: Auto Caption dialog doesn't show the list of elements
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-01-22 14:00 UTC by Xisco Faulí
Modified: 2019-01-23 10:26 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
How it looks in GTK3 (39.10 KB, image/png)
2019-01-22 14:00 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-01-22 14:00:42 UTC
Created attachment 148518 [details]
How it looks in GTK3

Maybe this is only with gtk 3.18.9

Steps to reproduce:
1. Open Writer
2. Insert an image
3. Context menu - Insert Caption
4. Click on Auto
-> See the image attached

Reproduced in

Version: 6.3.0.0.alpha0+
Build ID: 3fa4674615b747e219afe5bf0a9b689df3840439
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: 

Not reproduced in gtk2
Comment 1 Xisco Faulí 2019-01-22 14:06:09 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=320e8d38b7d0c5a47fdae13a657af9d9b896f279

author	Caolán McNamara <caolanm@redhat.com>	2018-12-12 11:02:57 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2018-12-12 21:09:39 +0100
commit 320e8d38b7d0c5a47fdae13a657af9d9b896f279 (patch)
tree 77862904b6d0d134a8775acc165bed856968a9ea
parent 3bd103064ba719013471d9664ea2c1f207b84d90 (diff)
weld SwCaptionOptDlg

Bisected with: bibisect-linux64-6.3

Adding Cc: to Caolán McNamara
Comment 2 Caolán McNamara 2019-01-22 14:45:27 UTC
I don't have the problem with a later gtk3 but I can guess what will fix it
Comment 3 Commit Notification 2019-01-22 17:08:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/da7495cdfc9dacff0256f8282e8953734bd3e03b%5E%21

Resolves: tdf#122880 list of obj types at 0 height with gtk 3.18

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2019-01-22 17:08:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2c6c905b5f24b254c047968e889f241d5f09b1bf%5E%21

Resolves: tdf#122880 list of obj types at 0 height with gtk 3.18

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2019-01-23 10:22:19 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2-0":

https://git.libreoffice.org/core/+/37d60f9f7b0ff854b9b01a1474cad4f261914242%5E%21

Resolves: tdf#122880 list of obj types at 0 height with gtk 3.18

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2019-01-23 10:26:27 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: 8f7c35072a6bbb33f6582c8c9a37a275c8d3cb14
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, thanks for fixing this!!