Bug 122958 - FILEOPEN DOCX, Arrows go missing when opened in LO (shapes)
Summary: FILEOPEN DOCX, Arrows go missing when opened in LO (shapes)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.1 target:6.1.6
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: OOXML-Shapes
  Show dependency treegraph
 
Reported: 2019-01-25 11:37 UTC by NISZ LibreOffice Team
Modified: 2019-01-31 11:26 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
The original file (223.00 KB, application/msword)
2019-01-25 11:38 UTC, NISZ LibreOffice Team
Details
Screenshot of the original document side by side in Word and Writer. (368.18 KB, image/png)
2019-01-25 11:38 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-01-25 11:37:32 UTC
Description:
When the attached document is opened in LO the arrow shapes go missing.

Steps to Reproduce:
    1. Open the attached document in LO and MSO.
    2. Notice the changes in LO.

Actual Results:
The arrows are missing in LO.

Expected Results:
The arrows shouldn’t go missing.


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 NISZ LibreOffice Team 2019-01-25 11:38:05 UTC
Created attachment 148635 [details]
The original file
Comment 2 NISZ LibreOffice Team 2019-01-25 11:38:37 UTC
Created attachment 148636 [details]
Screenshot of the original document side by side in Word and Writer.
Comment 3 Durgapriyanka 2019-01-25 16:56:22 UTC
Thank you for reporting the bug. I can confirm the bug present in

Version: 6.3.0.0.alpha0+
Build ID: 3c964980da07892a02d5ac721d80558c459532d0
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2018-12-12_02:07:45
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 4 Buovjaga 2019-01-30 12:35:28 UTC
Bibisected with win32-5.4 to https://gerrit.libreoffice.org/plugins/gitiles/core/+/82070481f34091718ee0ca0dd97826c7e3d7d79e%5E!/

reject bmps with unknown compression schemes

and RLE8/RLE4 compression with wrong bitmap depth

Adding Cc: to Caolán McNamara

The arrows are shapes and not bmps, but I did check with the blamed vs. previous commit.
Comment 5 Caolán McNamara 2019-01-30 13:05:12 UTC
bmp inside wmf inside a doc
Comment 6 Caolán McNamara 2019-01-30 13:32:23 UTC
odd, https://msdn.microsoft.com/en-us/library/cc250415.aspx explicitly states the valid values for compress, and this one has 1024/0x400 and 64/0x40 used which are not valid. Though these examples do work if its assumed to be 0.
Comment 7 Commit Notification 2019-01-30 21:14:16 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/61364e5b983acea4f8607cc74d8cc6c319a6e3a5%5E%21

Resolves: tdf#122958 bmps with weird compression values that work in mso

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Caolán McNamara 2019-01-30 21:17:50 UTC
fixed in master, backport to 6-2 and 6-1 in gerrit
Comment 9 Xisco Faulí 2019-01-31 11:04:42 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: d87bf779c7a5fc5512b53aa175222d8f71d6698b
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, thanks for fixing this!
Comment 10 Commit Notification 2019-01-31 11:25:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/b0583892ed754ffc7957e32e9c6cda3317a7a4b0%5E%21

Resolves: tdf#122958 bmps with weird compression values that work in mso

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2019-01-31 11:26:00 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/a7815e365bdb5544a0a9c63c6d730cf591f286d7%5E%21

Resolves: tdf#122958 bmps with weird compression values that work in mso

It will be available in 6.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.