Bug 123018 - Quote menu item has no function in Notebookbar Groupedbar
Summary: Quote menu item has no function in Notebookbar Groupedbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.2 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.1
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-28 15:26 UTC by OfficeUser
Modified: 2019-02-07 05:06 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (166.17 KB, image/jpeg)
2019-01-28 15:29 UTC, OfficeUser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description OfficeUser 2019-01-28 15:26:32 UTC
Quote menu item has no function. Please refer to attached screenshot.


Found using
Version: 6.2.0.2 (x64)
Build-ID: 2ce5217b30a543f7666022df50f0562f82be0cff
CPU-Threads: 8; BS: Windows 6.1; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded
Comment 1 OfficeUser 2019-01-28 15:29:04 UTC
Created attachment 148713 [details]
Screenshot
Comment 2 andreas_k 2019-01-30 12:22:08 UTC
It work on master, but in the UI file there is no difference between master and 6.2 rc can someone verify this bug.
Comment 3 Maxim Monastirsky 2019-01-30 12:50:35 UTC
(In reply to OfficeUser from comment #0)
> Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
That's the reason it doesn't work. The Groupedbar .ui files use a wrong command:

.uno:StyleApply?Style:string=Quotation&FamilyName:string=CharacterStyles

But the "Quotation" style name is just the English UI name of that style, so it won't work in anything except an English UI. To make it work across all languages, the correct internal name should be used, i.e. "Citation". (In addition, the manual label assigned in the .ui files should be removed, as the command label can be pulled from WriterCommands.xcu.)
Comment 4 andreas_k 2019-01-30 12:52:34 UTC
Thanks will prepare the fix.
Comment 5 Commit Notification 2019-02-04 12:10:35 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/abfcf71acffeeeda49943f52b84e77a198e6cf07%5E%21

tdf#123018 Notebookbar Grouped fix Quote Font Style

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-02-07 05:06:39 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/f5d0a81fc0eff8535c64488355a1b4412cfdbc66%5E%21

tdf#123018 Notebookbar Grouped fix Quote Font Style

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.