Bug 123320 - Writer crash if Paragraph edited after delete of custom Character Style used in Drop Caps
Summary: Writer crash if Paragraph edited after delete of custom Character Style used ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha1+
Hardware: All All
: highest critical
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0 target:6.2.1 target:6.1.6
Keywords: bibisected, bisected, needUITest, regression
Depends on:
Blocks:
 
Reported: 2019-02-11 09:08 UTC by Timur
Modified: 2019-02-11 16:41 UTC (History)
2 users (show)

See Also:
Crash report or crash signature: ["SfxItemSet::Get(unsigned short,bool)"]


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2019-02-11 09:08:54 UTC
Steps from https://bugs.documentfoundation.org/show_bug.cgi?id=123220#c5:

1. Open Test.odt attachment 149078 [details]
2. Right click delete the custom character style Test_Character_Style. 
3. Right click Paragraph - Edit or Format - Paragraph

Writer crashes. See with LO 6.1.3 and 6.3+. Not with 6.0. Seems regression.
Comment 1 Timur 2019-02-11 09:23:25 UTC
Crash report for 6.1. is at http://crashreport.libreoffice.org/stats/crash_details/ffdd08a3-651b-43df-bf22-0ea58c87d5ce
I also get crash report for 6.3 both Win and Lin but without link (why?).
Comment 2 Xisco Faulí 2019-02-11 09:38:29 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=a756795e4bd8606dd61283e3d3153a12d6658325

author	Caolán McNamara <caolanm@redhat.com>	2018-06-15 08:52:27 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2018-06-15 15:02:34 +0200
commit	a756795e4bd8606dd61283e3d3153a12d6658325 (patch)
tree	8c2b245b78073060e9f8faa3d140ff22b2b54a94
parent	5f7025c9aaad534ff835ddbda811bccbb53e031a (diff)
weld SwDropCapsPage

Bisected with: bibisect-linux64-6.1

Adding Cc: to Caolán McNamara
Comment 3 Commit Notification 2019-02-11 15:35:12 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/cac7541e1b2a1bbd0fca08853fd8323bb0078247%5E%21

Resolves: tdf#123320 non-existing drop caps char style

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2019-02-11 15:52:54 UTC
fixed in master, backports in gerrit
Comment 5 Xisco Faulí 2019-02-11 16:39:35 UTC
Issue verified in

Version: 6.3.0.0.alpha0+
Build ID: c7ad7849d54fd3dad67e7779102f65b8b2f04881
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, thanks for the quick fix!!
Comment 6 Commit Notification 2019-02-11 16:41:01 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/66f633086e2cf0c814df04627bff810d08e73329%5E%21

Resolves: tdf#123320 non-existing drop caps char style

It will be available in 6.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-02-11 16:41:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-1":

https://git.libreoffice.org/core/+/ad4e32ce3696de21d797e200b565e830320e14eb%5E%21

Resolves: tdf#123320 non-existing drop caps char style

It will be available in 6.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.