Bug 123418 - Showing all comments takes longer compared with 4.4.7.2
Summary: Showing all comments takes longer compared with 4.4.7.2
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, haveBacktrace, perf, regression
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2019-02-12 20:02 UTC by Telesto
Modified: 2019-02-18 12:15 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Callgrind output from master (1.93 MB, application/x-xz)
2019-02-18 12:10 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2019-02-12 20:02:42 UTC
Description:
Showing all comments takes longer compared with 4.4.7.2

Steps to Reproduce:
1. Open attachment 144526 [details] (bug 119075)
2. View -> Show comments

Actual Results:
1:35 seconds

Expected Results:
1 minute (with 4.4.7.2)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.0.alpha0+
Build ID: 0b21f6556b6fff76290d1095089da89532365215
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2019-02-12 20:31:38 UTC
Also with
Version: 6.3.0.0.alpha0+
Build ID: e0745a11597e5d57eb8001a295314e86810a6027
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-02-12_04:16:22
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 2 Roman Kuznetsov 2019-02-13 09:37:41 UTC
confirmed in

Версия: 6.2.0.3
ID сборки: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
Потоков ЦП: 4; ОС:Windows 6.1; Отрисовка ИП: по умолчанию; VCL: win; 
Локаль: ru-RU (ru_RU); UI-Language: ru-RU
Calc: threaded
Comment 3 Durgapriyanka 2019-02-14 18:18:57 UTC
I can confirm the bug is present. It takes 3.53 secs to show all the comments.

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 4 Buovjaga 2019-02-17 19:28:03 UTC
How did you display the comments in 4.4.7? I did it by selecting range D5:AR254 and right-click - show comment. It took 2:30 minutes in 4.4.7.
Master only took 1 minute.
Comment 5 Telesto 2019-02-17 19:51:14 UTC
(In reply to Buovjaga from comment #4)
> How did you display the comments in 4.4.7? I did it by selecting range
> D5:AR254 and right-click - show comment. It took 2:30 minutes in 4.4.7.
> Master only took 1 minute.

I confess, I initially compared "Show Comments" from view with selecting D5:AR254 in 4.4.7.2. However, got same results when repeating it by selecting D5:AR254

In this case I compared Version: 5.3.1.0.0+ with 6.3.. 

I can't explain your results..
Comment 6 Buovjaga 2019-02-18 12:10:49 UTC
Created attachment 149367 [details]
Callgrind output from master

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: e77beebb0d839f5dc0d4f9c4fd7cc9b7ccfd0175
CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 16 February 2019