Description: Showing all comments takes longer compared with 4.4.7.2 Steps to Reproduce: 1. Open attachment 144526 [details] (bug 119075) 2. View -> Show comments Actual Results: 1:35 seconds Expected Results: 1 minute (with 4.4.7.2) Reproducible: Always User Profile Reset: No Additional Info: Version: 6.3.0.0.alpha0+ Build ID: 0b21f6556b6fff76290d1095089da89532365215 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL
Also with Version: 6.3.0.0.alpha0+ Build ID: e0745a11597e5d57eb8001a295314e86810a6027 CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-02-12_04:16:22 Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL
confirmed in Версия: 6.2.0.3 ID сборки: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 Потоков ЦП: 4; ОС:Windows 6.1; Отрисовка ИП: по умолчанию; VCL: win; Локаль: ru-RU (ru_RU); UI-Language: ru-RU Calc: threaded
I can confirm the bug is present. It takes 3.53 secs to show all the comments. Version: 6.3.0.0.alpha0+ Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04 Locale: en-US (en_US); UI-Language: en-US Calc: threaded
How did you display the comments in 4.4.7? I did it by selecting range D5:AR254 and right-click - show comment. It took 2:30 minutes in 4.4.7. Master only took 1 minute.
(In reply to Buovjaga from comment #4) > How did you display the comments in 4.4.7? I did it by selecting range > D5:AR254 and right-click - show comment. It took 2:30 minutes in 4.4.7. > Master only took 1 minute. I confess, I initially compared "Show Comments" from view with selecting D5:AR254 in 4.4.7.2. However, got same results when repeating it by selecting D5:AR254 In this case I compared Version: 5.3.1.0.0+ with 6.3.. I can't explain your results..
Created attachment 149367 [details] Callgrind output from master Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: e77beebb0d839f5dc0d4f9c4fd7cc9b7ccfd0175 CPU threads: 8; OS: Linux 4.20; UI render: default; VCL: gtk3; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 16 February 2019
Win master still takes like 1min 47s, but Linux only takes 17s.
Repro Version: 7.1.0.0.alpha0+ (x64) Build ID: 7f16cabf00daa30e9284d2fb2494bd341352c25e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Showing comments is for 1 min and 5 sec, in master today. It seems good, no? Need we to search by bibisectioning where it is started to be only 1 minute? Version: 7.2.0.0.alpha0+ (x64) Build ID: 1ac449874c0e93ee7e7a9765053d392fde0067f4 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: cs-CZ (cs_CZ); UI: en-US Calc: threaded
10 sec and I see all comments in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 1516711eb7861a08cc9fd19ec867360737a6d070 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded interesting, it took 30 sec if Skia is enabled Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 1516711eb7861a08cc9fd19ec867360737a6d070 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded Buovjaga, Telesto, please retest it in cerrent master build. I don't know should I file a report about difference Skia/noSkia for this case
For me the CPU fans stop screaming after 25 sec, Skia or no. So it's a nice improvement compared to my comment 7. Let's close. Roman: you could reset your profile and test Skia again. I had some profile corruption that caused the comments to be rendered in a wrong way. Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 7cd5b35caa8d4fa9d0ba2b2c6ce4b88726ed2be6 CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: threaded Jumbo