Bug 124016 - [VIEWING] On LibreOffice Online, read only files should allow browsing and clicking links
Summary: [VIEWING] On LibreOffice Online, read only files should allow browsing and cl...
Status: REOPENED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 132090 133390 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-03-12 09:38 UTC by Franklin Weng
Modified: 2020-06-06 17:40 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Franklin Weng 2019-03-12 09:38:10 UTC
I shared an ods spreadsheet on Nextcloud, using CODE


此 Collabora Online Development Edition (CODE) 版本源自

LOOLWSD
4.0.1 (git hash: e1b0096)
LOKit
Collabora Office 6.0-25 (git hash: 518234a)

The link is at:
https://nextcloud.slat.org/index.php/s/yX8jfgwCSjgjg32

When I opened it anonymously it is read-only, but it would also block me from moving the cell frame to browsing the file.  Also, I put links in a column.  However when it is in read only mode I can not click the link either.

Read only mode does not allow editing, which makes sense.  But for the two actions of browsing and clicking links, it should be allowed.
Comment 1 Heiko Tietze 2019-03-12 10:52:43 UTC
You mean the cell A2 remains focused but you wish to click and, eg. copy/paste content or "scroll" by going down with the cursor? Makes sense, and for the hyperlink it's perfectly clear.
Comment 2 Franklin Weng 2019-03-12 12:43:48 UTC
(In reply to Heiko Tietze from comment #1)
> You mean the cell A2 remains focused but you wish to click and, eg.
> copy/paste content or "scroll" by going down with the cursor? Makes sense,
> and for the hyperlink it's perfectly clear.

Clicking the hyperlink is one.  The other is to use arrow keys to move the focus frame in order to browse the whole sheet.  No need to copy/paste since it is read-only.

BTW, I haven't tried but I believe not only Calc, but also Writer/Impress online have this problem too (not able to click the hyperlink).
Comment 3 Jean-Noel Rouchon 2019-10-16 21:22:28 UTC
I confirm inactive links when read-only file on writer

LOOLWSD
4.0.7 (git hash: 59283de)
LOKit
Collabora Office 6.0-29 (git hash: f873d84)

From nextcloud.

Example at :
https://cloud1.zourit.net/index.php/s/oyyKRWeB3ZxE25F
Comment 4 Aron Budea 2020-05-26 00:56:45 UTC
*** Bug 132090 has been marked as a duplicate of this bug. ***
Comment 5 Aron Budea 2020-05-26 00:57:31 UTC
*** Bug 133390 has been marked as a duplicate of this bug. ***
Comment 6 Ambika Nair 2020-05-27 20:20:26 UTC
Any idea where this issue stems from? Really interested in tackling it; I'd appreciate any suggestions as to steps I can take to ignite or re-ignite a discussion about solving the matter. Thanks!
Comment 7 Michael Meeks 2020-05-29 15:14:20 UTC
Hi Ambika, I -think- that we fixed this in CODE 4.2.x - can you confirm it still recurs in master online ? (if not lets close the bug) beyond that - I would compile a version with --enable-debug, and you should see all the protocol traffic in the javascript console from the core. I would play around clicking on the link etc. and seeing what events you get & how we react to them.

commit 2462bf7a19daa56fe2fea9681587c22e6503c360
Author: mert <mert.tumer@collabora.com>
Date:   Wed Feb 26 16:58:30 2020 +0300

    hyperlink popup clean up
    
    hyperlink popups shouldnt contain href for links
    also we shouldnt show popup for internal links
    core must handle it

has some great code pointers: git log -u -1 2462bf7a19daa56fe2fea9681587c22e6503c360

But check the problem is still there first =)

Thanks !

Michael.
Comment 8 Aron Budea 2020-06-01 04:48:03 UTC
(In reply to Michael Meeks from comment #7)
> But check the problem is still there first =)
As far as I can see this is indeed working now:
- clicking on a linked text brings up the bubble with the URL, then clicking on that opens the link,
- Ctrl-clicking on a linked text brings up the dialog where you can confirm if you want to visit the link.

A few possible UX improvements could be:
- in deskop LO, hovering over the URL with Ctrl pressed changes the pointer to a hand (in Writer, not in Calc, tho), this doesn't happen in online,
- in the Ctrl-click dialog, there's an option to edit the URL, this button should be deactivated in read-only mode (the changes are discarded anyway).
Comment 9 Michael Meeks 2020-06-01 08:32:58 UTC
Lets close the bug rather than mingling in other feature requests =)
Comment 10 Guillaume Dupuy 2020-06-06 17:18:24 UTC
I'm still having the bug with the following version :
LOOLWSD
4.2.3 (git hash: 6144a6c)

LOKit
Collabora Office 6.2-12 (git hash: 8dce0b1)

As far as I was able to see with my limited git-fu, the fix is included in my version (which I got from collabora's debian10 repository)

Here's an example spreadsheet : https://nextcloud.glorf.fr/s/iGt5xn4c6286zex
And a writer file : https://nextcloud.glorf.fr/s/ALkCAZqs9QiXkXX

I'm also running Nextcloud 18.0.5 (but it shouldn't matter), and have tried accessing the file on firefox 77 (in safe mode and onmy regular profile) and google-chrome (on a fresh install with no extension or anything installed) on Linux.