Bug 124264 - UI Close button should be Cancel in Data Field Options window
Summary: UI Close button should be Cancel in Data Field Options window
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0
Keywords: easyHack, topicUI
Depends on:
Blocks: Dialog-Buttons-Unification
  Show dependency treegraph
 
Reported: 2019-03-22 10:26 UTC by Gabor Kelemen (allotropia)
Modified: 2019-03-22 16:30 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2019-03-22 10:26:13 UTC
The button to close the Data Field Options window without saving changes is called Close instead of the more common Cancel.

Look at attachment #149903 [details] from bug #124012
The Close button is inconsistent with the other two windows Cancel buttons.

(Also: the order of Close - OK should be switched too for the same reason to: OK - Cancel)

This is coming from: 
sc/uiconfig/scalc/ui/datafieldoptionsdialog.ui
Comment 1 Commit Notification 2019-03-22 16:24:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/e8f2f923ae12bea76379c917f2090e7a5e61d860%5E%21

Resolves: tdf#124264 Close should be Cancel

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.