Bug 124318 - FILEOPEN: XLS Hyperlink URL incorrect
Summary: FILEOPEN: XLS Hyperlink URL incorrect
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.3.0 target:6.2.3 target:7.2.0
Keywords: bibisected, bisected, filter:xls, regression
: 123678 124202 124501 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-03-24 22:14 UTC by raal
Modified: 2021-03-15 14:20 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
test file (23.50 KB, application/vnd.ms-excel)
2019-03-24 22:17 UTC, raal
Details
printscreen (39.98 KB, image/png)
2019-03-24 22:17 UTC, raal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2019-03-24 22:14:48 UTC
Description:
Invalid hyperlink URL 

Steps to Reproduce:
open attached file
edit hyperlink (ctrl+k)
see URL


Actual Results:
https://espaceclient.lapostemobile.fr/mobile/identification/authentification%00塹ᴻ䡿ⲯ嶂藄挧%00%00ꮥ%00

Expected Results:
https://espaceclient.lapostemobile.fr/mobile/identification/authentification


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 raal 2019-03-24 22:16:46 UTC
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin ; Could you possibly take a look at this one?
Thanks
 b97b92861bd66bc736a441ece45ae3acf50b512c is the first bad commit
commit b97b92861bd66bc736a441ece45ae3acf50b512c
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Aug 1 23:53:51 2018 +0200

    source 52f69445c55c9af8ad97bee6da335b4592d56d4d

author	Noel Grandin <noel.grandin@collabora.co.uk>	2018-08-01 17:03:18 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2018-08-01 21:40:17 +0200
commit 52f69445c55c9af8ad97bee6da335b4592d56d4d (patch)
tree d88b7e629213b157af2113b64e54aaf08fc2cfc7
parent 28580110807a38e3ba6f8385f22871b8dfe0a910 (diff)
loplugin:stringloop in sc
Comment 2 raal 2019-03-24 22:17:07 UTC
Created attachment 150266 [details]
test file
Comment 3 raal 2019-03-24 22:17:36 UTC
Created attachment 150267 [details]
printscreen
Comment 4 Commit Notification 2019-03-25 11:45:33 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/756252ce13f541049af620983f6741223d44573b%5E%21

tdf#124318 FILEOPEN: XLS Hyperlink URL incorrect

It will be available in 6.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2019-03-25 15:25:26 UTC
*** Bug 123678 has been marked as a duplicate of this bug. ***
Comment 6 Commit Notification 2019-03-25 15:32:04 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/2508f949f1f20bb353f8bef1bd908f9cf3b039ef%5E%21

tdf#124318 FILEOPEN: XLS Hyperlink URL incorrect

It will be available in 6.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2019-03-25 19:51:19 UTC
*** Bug 124202 has been marked as a duplicate of this bug. ***
Comment 8 Xisco Faulí 2019-03-27 18:06:06 UTC
Verified in

Version: 6.3.0.0.alpha0+
Build ID: 705558aa455403cd006993f95b5b13981fdb3483
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Noel Grandin, thanks for fixing this issue!!
Comment 9 Xisco Faulí 2019-04-02 14:36:58 UTC
*** Bug 124501 has been marked as a duplicate of this bug. ***
Comment 10 Commit Notification 2021-03-15 14:20:00 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6e5081011d7727536a5ff8eb604907cdb041d2b1

tdf#124318: sc: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.