Bug 124376 - Sidebar Separator lines
Summary: Sidebar Separator lines
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-UI-UX
  Show dependency tree / graph
 
Reported: 2019-03-27 20:32 UTC by andreas_k
Modified: 2021-03-30 10:54 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Sidebar Line Separators (31.85 KB, image/png)
2019-03-27 20:32 UTC, andreas_k 		Details
MSO 2019 on windows (44.80 KB, image/jpeg)
2019-03-28 10:31 UTC, andreas_k 		Details
Floating Sidebar (42.64 KB, image/png)
2019-03-28 10:48 UTC, andreas_k 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-03-27 20:32:42 UTC 
Created attachment 150330 [details]
Sidebar Line Separators

I'd recommend to remove the Lines around the sidebar, like you see in the attachment.

But I also recommend to have an horizontal Line at bottom of the top Toolbar. For example the Statusbar has an horizontal line at top.

thanks
Comment 1 Heiko Tietze 2019-03-28 10:18:18 UTC 
It's up to the system theme how lines around controls are shown. So nothing to do for us here. => NAB/WFM
Comment 2 andreas_k 2019-03-28 10:20:37 UTC 
Thats not true. Why is the line for the sidebar thicker than the line at the statusbar.
Comment 3 andreas_k 2019-03-28 10:31:09 UTC 
Created attachment 150348 [details]
MSO 2019 on windows

The MSO 2019 show an vertical line to the sidebar (which is a thin line like on the statusbar) which is fine, but use everywhere the same line.

As you can see on MSO 2019 there is an line at the toolbar, statusbar and sidebar but all are thin and have the same thickness, color, ...
Comment 4 Heiko Tietze 2019-03-28 10:42:26 UTC 
The status bar is not a themed control and a bad example to compare. Look at the deck title when the sidebar is expanded.

Anyway, controls may have a borderstyle and windows are created with winbits that may contain WB_NOBORDER. However, the sidebar is a floating window (you can undock it) and can be expanded. Provided the tweak is possible it has to look nicely in all situations and also remain usable (content grouping might be affected).
Comment 5 andreas_k 2019-03-28 10:48:24 UTC 
Created attachment 150349 [details]
Floating Sidebar

If the sidebar is floating you have a separate window around it.

Notebookbar has also an horizontal thin like (like Statusbar)
Comment 6 Thomas Lendo 2019-03-28 21:44:24 UTC 
The less lines the better. I like the suggestion in Andreas' first image.

(Not talking about the other lines at the toolbar. Please one ticket for one issue.)
Comment 7 Tomaz Vajngerl 2019-03-29 13:09:04 UTC 
I have a patch for that somewhere :)
Comment 8 andreas_k 2019-03-29 13:11:53 UTC 
Awesome
Comment 9 Heiko Tietze 2019-04-02 07:56:35 UTC 
(In reply to Tomaz Vajngerl from comment #7)
> I have a patch for that somewhere :)

Then let's see how it looks.
Comment 10 andreas_k 2019-04-08 19:47:00 UTC 
Screenshot please
Comment 11 Tomaz Vajngerl 2019-04-09 04:26:52 UTC 
yeah.. I need to get the patch "out of ethanol" (lots of changes happened)
Comment 12 andreas_k 2019-04-23 19:38:58 UTC 
(In reply to Tomaz Vajngerl from comment #11)
> yeah.. I need to get the patch "out of ethanol" (lots of changes happened)

please
Comment 13 Heiko Tietze 2019-05-28 08:28:28 UTC 
Removing UX and assigning to Tomaz....
Comment 14 Xisco Faulí 2019-09-26 10:24:11 UTC 
Dear Tomaz Vajngerl,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 15 andreas_k 2020-08-26 08:55:35 UTC 
(In reply to Tomaz Vajngerl from comment #11)
> yeah.. I need to get the patch "out of ethanol" (lots of changes happened)

Tomaz could we do the theme refreshment? And with we I mean you (I will help as much as I can).
Comment 16 Heiko Tietze 2020-09-29 06:35:54 UTC 
What is the relation of this ticket to bug 133690?
Comment 17 Xisco Faulí 2021-03-30 10:54:57 UTC 
Setting to RESOLVED WORKSFORME since the commit fixing this issue hasn't been
identified.