Bug Hunting Session
Bug 124584 - Wrong render Bullet item in Dialog Paragraph Style
Summary: Wrong render Bullet item in Dialog Paragraph Style
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: Paragraph-Dialog
  Show dependency treegraph
 
Reported: 2019-04-07 08:26 UTC by Roman Kuznetsov
Modified: 2019-09-03 13:09 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot with problem (192.70 KB, image/png)
2019-04-07 08:29 UTC, Roman Kuznetsov
Details
Screenshot from Windows 10 (23.69 KB, image/png)
2019-04-07 08:37 UTC, Roman Kuznetsov
Details
kde5-screen (20.10 KB, image/png)
2019-04-08 06:27 UTC, Vera Blagoveschenskaya
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-04-07 08:26:33 UTC
Description:
KDE5 Wrong render Bullet item in Dialog Paragraph Style

repro in

Version: 6.3.0.0.alpha0+
Build ID: 9079da7f62febaf4cef0b77320c31b4e8bb6b5a5
CPU threads: 4; OS: Linux 4.18; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-04-06_02:52:37
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded

but not in latest Windows build (windows 10)

regression from bug 124471

Steps to Reproduce:
1. Open Writer
2. Select Format->Paragraph
3. Go to tab Outline & Numbering
4. Open drop-down list Numbering style
5. Look at 4 from top "Bullet" item. There isn't a symbol-bullet near Bullet

Actual Results:
There isn't a symbol-bullet near Bullet

Expected Results:
There is a symbol-bullet near Bullet


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Roman Kuznetsov 2019-04-07 08:29:44 UTC
Created attachment 150575 [details]
Screenshot with problem
Comment 2 Roman Kuznetsov 2019-04-07 08:37:00 UTC
Created attachment 150576 [details]
Screenshot from Windows 10
Comment 3 Vera Blagoveschenskaya 2019-04-08 06:27:58 UTC
Created attachment 150592 [details]
kde5-screen

Can't confirm - for me, view is OK.
Pls look at the screenshot.

Version: 6.3.0.0.alpha0+
Build ID: 84d4125b28c384f9ac6285737a5bb9093978798e
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-04-06_20:07:58
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 4 Vera Blagoveschenskaya 2019-04-08 06:28:50 UTC
For GTK3 is also OK.

Version: 6.3.0.0.alpha0+
Build ID: 84d4125b28c384f9ac6285737a5bb9093978798e
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-04-06_20:07:58
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 5 Michael Weghorn 2019-04-08 06:32:26 UTC
Cannot confirm either on Debian testing with

Version: 6.3.0.0.alpha0+
Build ID: f3fc127dc007f32355859ae4fc7d34916c500a18
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: kde5; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded
Comment 6 Roman Kuznetsov 2019-04-08 18:56:17 UTC
I have tried :

1. to delete user profile
2. to reinstall open symbol font

no effect =( problem still here...

may be some Kubuntu 18.10 problem?
Comment 7 Maxim Monastirsky 2019-04-08 23:05:05 UTC
The items in the list box usually displayed with the system UI font, and if that font doesn't have some symbol it uses a fallback font, which might or might not be OpenSymbol. e.g. on my system I can reproduce the bug as long as I have the Abyssinica SIL font installed, because that what it picks as a fallback font for this symbol (UI font set to Cantarell). Only when I remove Abyssinica SIL, it finally picks OpenSymbol.

(In general, the current approach with symbols in style names seems a bit risky to me, as we don't set the control font explicitly to OpenSymbol, but instead rely on 3rd party font creators to not override what we provide in OpenSymbol...)
Comment 8 Roman Kuznetsov 2019-08-30 14:31:11 UTC
Caolan, Jan-Marek can you look at this please?
Comment 9 Jan-Marek Glogowski 2019-08-30 16:10:16 UTC
(In reply to Maxim Monastirsky from comment #7)
> The items in the list box usually displayed with the system UI font, and if
> that font doesn't have some symbol it uses a fallback font, which might or
> might not be OpenSymbol. e.g. on my system I can reproduce the bug as long
> as I have the Abyssinica SIL font installed, because that what it picks as a
> fallback font for this symbol (UI font set to Cantarell). Only when I remove
> Abyssinica SIL, it finally picks OpenSymbol.
> 
> (In general, the current approach with symbols in style names seems a bit
> risky to me, as we don't set the control font explicitly to OpenSymbol, but
> instead rely on 3rd party font creators to not override what we provide in
> OpenSymbol...)

From: https://bugs.documentfoundation.org/show_bug.cgi?id=124471#c8

(In reply to Daniel Grigoras from comment #8)
> What if there are multiple lists having the same bullets, but different
> indentations, or starting with the same bullet for level 1, but continuing
> with different bullets for subsequent levels?
> 
> In my case, having two lists with the same bullets and bullet structure, but
> with one having a different indentation of the list items led to the second
> list style not being shown among the list styles. For example, List 1 and
> List 5 had the same bullets, with List 5 only having the list items
> indented. List 1 was displayed as "Bullet •", but List 5 was not shown
> anywhere when I worked with v6.3, which is why I now downgraded to v6.2

These are quite a good reason to actually revert the change from bug 124471.

commit 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c
Author: Roman Kuznetsov <antilibreoffice@gmail.com>
Date:   Tue Apr 2 08:30:17 2019 +0100

    tdf#124471 Change bullet styles names in Style section of Sidebar
    
    Change-Id: I1a6acd3b9496cf83cd0e1ef6d808443cd40ae2c3
    Reviewed-on: https://gerrit.libreoffice.org/70121
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

As you can already see in the problem screenshot, there is an edit "Edit Style" button, where you can change the bullet type. Interestingly I can't change the name of these styles. If this is all expected, than including  the bullet type in the name even makes less sense.

Now unfortunately this was a string change, but probably they can easily be restored to the original ones?

Or am I missing something?
Comment 10 Caolán McNamara 2019-09-03 13:09:56 UTC
For the kde/gtk2/gen case we could probably bodge our glyph fallback PhysicalFontCollection::GetGlyphFallbackFont to suggest OpenSymbol as the fallback for these bullet glyphs before asking fontconfig for a fallback font.

But that would't have any effect on the window title of Edit Style where the name is displayed