Bug 124935 - FILE OPEN: Formatting of spreadsheet broken: cells get wrong style applied
Summary: FILE OPEN: Formatting of spreadsheet broken: cells get wrong style applied
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-04-24 15:34 UTC by Cor Nouws
Modified: 2019-04-27 11:16 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
spreadsheet showing the problem (33.84 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-04-24 15:34 UTC, Cor Nouws 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2019-04-24 15:34:17 UTC 
Created attachment 150979 [details]
spreadsheet showing the problem

Attaching a file.
On opening, cells get the wrong styles applied.

Noticed in Version: 6.3.0.0.alpha0+
Build ID: 89b1a00e08d8938714dd493fa27f08ba8d9b618d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-04-21_15:52:39
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded


Still OK in Version: 6.3.0.0.alpha0+
Build ID: 84d4125b28c384f9ac6285737a5bb9093978798e
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-04-06_20:07:58
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Cor Nouws 2019-04-24 15:37:35 UTC 
(it is easy visible since the styles have a different background color )
Comment 2 Aron Budea 2019-04-24 18:51:44 UTC 
Bibisected it to the following commit. It also doesn't occur anymore in a build from today, so I assume the fix mentioned in bug 81765 comment 24 fixed it.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=003d11f410b7e515981b3efbd65d936d94d87121
author		Noel Grandin <noel.grandin@collabora.co.uk>	2019-04-20 08:32:33 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2019-04-20 18:18:20 +0200

"tdf#81765 slow loading of .ods with >1000 of conditional formats"

The likely fixing commit (needs verification if you want to be sure):
https://cgit.freedesktop.org/libreoffice/core/commit/?id=1e3d0a57689006cd7244481958025177c01e4d09
author		Noel Grandin <noel.grandin@collabora.co.uk>	2019-04-23 11:23:36 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2019-04-23 19:56:53 +0200

"fix bad comparison in StrCmp/StrLess

comment from Miklos:
> Won't this do a comparison of two null-terminated strings, while
> the strings here are utf16, i.e. abc is a\0b\0c\0? That would mean
> in practice you compare the first char only.

introduced in commit 003d11f410b7e515981b3efbd65d936d94d87121"
Comment 3 Cor Nouws 2019-04-27 11:16:07 UTC 
indeed, fixed in Version: 6.3.0.0.alpha0+
Build ID: 5e4c1e6ba425ce0b75864e4584a846957b032e61
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-04-25_17:33:40
Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US
Calc: threaded

thanks Aron.