Bug 124969 - Dark theme option to read/view/write in LO.
Summary: Dark theme option to read/view/write in LO.
Status: RESOLVED DUPLICATE of bug 141986
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.4.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
: 127707 129145 (view as bug list)
Depends on:
Blocks: UI-Theming
  Show dependency treegraph
 
Reported: 2019-04-26 01:55 UTC by Prabesh432@gmail.com
Modified: 2023-01-31 13:48 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Prabesh432@gmail.com 2019-04-26 01:55:31 UTC
Description:
Till now, we have to change "Application color" to do this. But this will create a problem when you want to:
i) view the new document
ii) insert a table which doesn't appear.
etc. 

When there is a default option of dark mode (like MS office), everything will be back and clear. Inserting the table will be visible because dark mode will have its own set of "Application color". And all other will get visible too.

Actual Results:
for now, I have to use "restart in Safe mode" option to view any new document because I don't want to change my set of "application color" every time I see new document. 

But it's easier when its MS office. I want that concept in this platform too.

Expected Results:
The exception is high because I know this issue will be ignored. so, god bless LO

(Ubuntu 19.04 user) Please bring "Dark mode" option. Use MS office to notice the difference.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Comment 1 V Stuart Foote 2019-04-26 12:19:21 UTC
And once again this is a duplicate, issue is addressed for enhancement, and requirements and dev options stated in bug 118320 --please stop spamming the BZ!

*** This bug has been marked as a duplicate of bug 118320 ***
Comment 2 V Stuart Foote 2019-04-26 12:31:12 UTC
Actually read this a third time. And going to retract the "Duplicate" claim.

Two issues. Application Colors, set to Automatic, draw their colors from the Theme reported by the DE (the reason we can't do anything on Win32 builds--where at Windows 10 the "Dark Mode" DE, and any UWP apps do not report theme colors). Ubuntu offers unlimited number of Dark themes, all of which LibreOffice will respond to.

You can already override DE Theme colors setting elements--and then saving to your own custom color theme. That customize theme for your dark DE is available for use--why is that not sufficient?

Some screen shot might help.
Comment 3 Heiko Tietze 2019-05-28 08:12:58 UTC
@Prabesh432: please reply to comment 2. Otherwise we have to resolve your input as insufficientdata.
Comment 4 Prabesh432@gmail.com 2019-05-28 11:01:47 UTC
I am Ubuntu 19.04 user. After like 5 years using Windows 10 pro with it's MS word which blend my work accordingly to dark mode if a user select "dark theme" in app setting, which I really enjoyed it. 

Entire thing goes black. Even the paper which I am writing upon. 

If I insert a table or an object (let say Rectangle), it's border remain white. I don't have to do anything. MS Word understand what theme user has preferred and blend in with that environment.

This is not possible in Libre because Libre depends on Gnome and it's tweaks. 

Which is not the problem. Problem is only application part goes dark not the content. 

Because of this we can to toogle all options from font color, table color etc.

This will damage the default settings and it need huge time to adjust each component.

Because of this I use Libre office and Open office. Libre Office where I write documents in dark preferences. And Open office to open documents because I can view it from Libre office anymore unless I reset the settings.
Comment 5 Xisco Faulí 2019-05-30 11:00:14 UTC
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
else confirms it.
Comment 6 Prabesh432@gmail.com 2019-06-28 06:04:27 UTC
I wonder what's not to understand.

To completely, u to have a Windows OS, MS Word 2019 (paid one) and select "Dark theme" in-app setting. And the magic begins.

And now try to do the thing on LibreOffice, and notice the difference.

Spend time inserting tables, shapes, pictures, writing, etc on both.

Which one do u feel comfortable? LibreOffice or MS Word.

In my experience MS Word because we don't need to tweak a lot of color pattern in order to see objects, images or word to see, unless if its LibreOffice.



(In reply to Xisco Faulí from comment #5)
> You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
> else confirms it.

(In reply to Xisco Faulí from comment #5)
> You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone
> else confirms it.
Comment 7 Tomaz Vajngerl 2019-06-28 07:07:11 UTC
If you just say "do it like MS Office 2019" then we can't do anything for you as we don't have it and you don't want to do the work to describe or screenshot exactly what you mean.

There were many approaches in the past for dark mode in MS Office, which not all of them are even possible in LibreOffice (without a lot of work). It is possible to get a complete "dark theme" experience even in LibreOffice (on Linux), but you need to put a bit of work into it unfortunately.  

Anyway even with 2 responses you still fail to clarify HOW it is different and you generally just say - "try MSO 2019 and figure it out for yourself", where probably a screenshot or 2 would probably be enough.
Comment 8 Buovjaga 2019-09-23 07:19:19 UTC
*** Bug 127707 has been marked as a duplicate of this bug. ***
Comment 9 Hussam Al-Tayeb 2019-12-03 07:31:04 UTC
*** Bug 129145 has been marked as a duplicate of this bug. ***
Comment 10 Hussam Al-Tayeb 2019-12-03 07:33:21 UTC
As mentioned on bug 129145, some statusbar indicator are not easily visible on Adwaita Dark theme using Tango LO theme.
Screenshot: https://bugs.documentfoundation.org/attachment.cgi?id=156253
Sugestions: Use white(high contrast) variants of the single page/multiple page, - and + signs on dark gtk themes and the same for the modified document indicator.
Comment 11 Rizal Muttaqin 2019-12-03 10:06:48 UTC
(In reply to Hussam Al-Tayeb from comment #10)
> As mentioned on bug 129145, some statusbar indicator are not easily visible
> on Adwaita Dark theme using Tango LO theme.
> Screenshot: https://bugs.documentfoundation.org/attachment.cgi?id=156253
> Sugestions: Use white(high contrast) variants of the single page/multiple
> page, - and + signs on dark gtk themes and the same for the modified
> document indicator.

The component you mentioned here are alreay part of icon theme but unfortunately it won't change immediately after we change icon the the dark version. LO should be restarted completely to see the changes.
Comment 12 Hussam Al-Tayeb 2019-12-03 10:21:41 UTC
(In reply to Rizal Muttaqin from comment #11)
> The component you mentioned here are alreay part of icon theme but
> unfortunately it won't change immediately after we change icon the the dark
> version. LO should be restarted completely to see the changes.

I'm not sure I am following you. I changed the gtk theme and restarted libreoffice. The issue here is lack of "dark" version of Tango?
Comment 13 Hussam Al-Tayeb 2019-12-03 17:27:33 UTC
I'm trying to make this easier to decipher for Libreoffice developers. So, to confirm, what we need here are two things?
1) Dark versions of some indicator icons in tango theme.
2) Ability to change the indicator icons on the fly without restart LibreOffice.

Correct?
Comment 14 V Stuart Foote 2019-12-03 22:24:31 UTC
(In reply to Hussam Al-Tayeb from comment #13)
> I'm trying to make this easier to decipher for Libreoffice developers. So,
> to confirm, what we need here are two things?
> 1) Dark versions of some indicator icons in tango theme.

Hmm, not so sure... 

Currently the project maintains Sifr (Dark), and Breeze (Dark) both of which are presentable on the 'Adwaita (dark)' theme. I just checked and for Fedora 31 with the Adwaita Dark shell, and for LibreOffice the (Automatic) icon theme assigned is Breeze (Dark), not Tango.

There can never be LibreOffice provided 'Dark' versions of Tango--which is an unsupported and incomplete icon theme, we've made some critical additions, but adding a whole 'dark' mode theme is unlikely. Especially as no 'dark' theme was "defined" for the Tango artwork guidelines [1]. So, should a Tango icon end up as a fall back for other themes, it will always result in low contrast in a 'dark' theme.  

> 2) Ability to change the indicator icons on the fly without restart
> LibreOffice.
> 

We actually do not need to restart LibreOffice to get Statusbar icons to update. You just exit any active module(s) (ending up back to Start Center) and relaunch the module. 

But I do agree the Statusbar should be able to refresh after change of icon style, just like happens for toolbars/sidebar/menus/NB already. Something is off in the Statusbar that it does not.

=-ref-=
[1] http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines

=-testing-=
Testing with Fedora 31 with Adwaita (dark) theme selected from GTK Tweaks
Version: 6.3.3.2.0+
Build ID: 6.3.3.2-7.fc31
CPU threads: 4; OS: Linux 5.3; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 15 Hussam Al-Tayeb 2019-12-03 23:18:04 UTC
On xfce 4.14, it defaults to Tango. It defaults to Breeze on KDE. But I can choose breeze or sifr dark variants on either desktop and they work well.
Comment 16 Heiko Tietze 2019-12-04 07:22:17 UTC
(In reply to Hussam Al-Tayeb from comment #13)
> I'm trying to make this easier to decipher for Libreoffice developers. So,
> to confirm, what we need here are two things?

Icons are the one piece (as Stuart pointed out; and XFCE is not among the special desktop environments we can detect), font is the other. There are still several controls with hard-coded color. And we also have to talk about the application colors to maintain the contrast with changing background brightness.
Comment 17 Heiko Tietze 2022-01-26 09:32:53 UTC
For bug 141986 a "LibreOffice Dark" application color set was implemented. It was always possible to change these colors and the patch just ships a new default set.

This will not solve the problem though. Application colors are used for the document background, the grid, comments etc. and not the interface. But this part is handled in bug 118320 and co.

*** This bug has been marked as a duplicate of bug 141986 ***