Bug 125642 - Layout issues of new Bullet & Numbering dialog in Impress when VCL plugin is not gtk
Summary: Layout issues of new Bullet & Numbering dialog in Impress when VCL plugin is ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Gülşah Köse
URL:
Whiteboard: target:6.4.0 target:6.3.0.1
Keywords: bibisectNotNeeded, regression
Depends on:
Blocks: Impress-Bullet-Numbering-Dialog
  Show dependency treegraph
 
Reported: 2019-06-02 14:20 UTC by Roman Kuznetsov
Modified: 2019-07-30 16:04 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
New B&N dialog (win 7) (36.99 KB, image/jpeg)
2019-06-02 14:24 UTC, Roman Kuznetsov
Details
screenshot with SAL_USE_VCLPLUGIN=gen (26.43 KB, image/png)
2019-06-06 06:23 UTC, Andras Timar
Details
screnshot 1 (54.73 KB, image/jpeg)
2019-07-22 14:33 UTC, Roman Kuznetsov
Details
Screenshot 2 (55.64 KB, image/jpeg)
2019-07-22 14:33 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-06-02 14:20:35 UTC
Description:
Terrible new Bullet & Numbering dialog in Impress

Steps to Reproduce:
1. Open Impress
2. Select Format->Bullet and Numbering
3. Look at terrible view of dialog

Actual Results:
Terrible new Bullet & Numbering dialog in Impress

Expected Results:
Nice new Bullet & Numbering dialog in Impress


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 93477d1a963e38e3319013e43835a8ffef200972
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-02_10:16:52
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded
Comment 1 Roman Kuznetsov 2019-06-02 14:24:57 UTC
Created attachment 151853 [details]
New B&N dialog (win 7)
Comment 2 Roman Kuznetsov 2019-06-02 14:26:24 UTC
problem was started from https://gerrit.libreoffice.org/#/c/71944/
Comment 3 Telesto 2019-06-02 15:52:12 UTC
Same here
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 93477d1a963e38e3319013e43835a8ffef200972
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-02_10:16:52
Locale: it-IT (nl_NL); UI-Language: en-US
Calc: threaded
Comment 4 Andras Timar 2019-06-02 17:38:08 UTC
The dialog looks great on Linux. We have to check why it falls apart on Windows. Maybe it's not particular to this dialog, but a more general issue.
Comment 5 V Stuart Foote 2019-06-02 23:16:15 UTC
Hmm, confirming as well.

We briefly had the dialog panels split into a Format -> "Bullets and Numbering" --showing Position & Customize; and a Format -> "Numbering and Position"--which already had layout issues.

Version: 6.3.0.0.alpha1+ (2019-05-28)
Build ID: 37103a3f008c13dee21d55c8da9e6af807b1997c

Now, current master/6.4.0alpha0, the Bullets and Numbering dialog has been replaced with the broken Numbering and Position panels--and the Position and Customize panels are missing.

Version: 6.4.0.0.alpha0+ (x86) (2019-06-02)
Build ID: 88f48b51f3cf25c78db278499d46d4913ab442ed
Comment 6 Mike Kaganski 2019-06-06 01:17:04 UTC
https://gerrit.libreoffice.org/73577
Comment 7 Commit Notification 2019-06-06 05:53:28 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/2265574dd571593e0070754ebd053eef6098ac98%5E%21

tdf#125642: fix minimal sizes of dialog and its elements

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Andras Timar 2019-06-06 06:06:49 UTC
After https://cgit.freedesktop.org/libreoffice/core/commit/?id=2265574dd571593e0070754ebd053eef6098ac98 and https://cgit.freedesktop.org/libreoffice/core/commit/?id=9823786d74bb86c7827a777ef517ba753f58b872 things improved a lot (thanks Mike and Caolán).

There are still a few issues left. Gülsah, you can test it on Linux, too. Start LibreOffice with: SAL_USE_VCLPLUGIN=gen instdir/program/simpress

On the fist open, when type is Bullet:
1) Alignment buttons don't have graphics
2) Preview area is scrollable with the mouse wheel, probably it's slightly too small.
Comment 9 Andras Timar 2019-06-06 06:23:16 UTC
Created attachment 151951 [details]
screenshot with SAL_USE_VCLPLUGIN=gen

When switching from Type: Bullet to Type: 1, 2, 3, the "Start at:" widget appears, at the same time Preview and Level widgets become bigger and overlap with the buttons at the bottom of the dialog.
Comment 10 Commit Notification 2019-06-06 07:57:30 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/4b2a8ca9297466fe82c002e5d9c40222e8cc84e1%5E%21

tdf#125642: fix minimal sizes of dialog and its elements

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Roman Kuznetsov 2019-07-22 14:33:27 UTC
Created attachment 152942 [details]
screnshot 1

I can add some additional info about Layout issues here:

all controls in the dialog don't have an alignment (see screenshots with red line)
Comment 12 Roman Kuznetsov 2019-07-22 14:33:55 UTC
Created attachment 152943 [details]
Screenshot 2
Comment 13 Heiko Tietze 2019-07-22 17:56:27 UTC
Commented on https://gerrit.libreoffice.org/#/c/71944/:

* Section headers are done in bold with indented content, you do this only for Properties but with expanders for Position etc. Expanders makes not much sense here.
* The alignment of type and character controls is not pixel-perfect.
* It _would be nice_ to get a grid for the most recently used characters.
* We merged the alignment into the fine-tuning - so it comes after color and does not occupy extra space somewhere else.
* The color dropdown has an issue (two triangles).
* At the levels list we have 1-10 (=all) as an extra item but this would better go into a checkbox that disables the individual section (would be the default).
* When I wheel-scroll through the type, the depending controls are not updated (needs to be a click).
* "Apply to Master" is too big (and has no accelerator key, likewise some other controls).
* The dialog should also become the standard in other modules.

And later:

"Talked with Andreas Kainz about the new layout and the grid is actually important because it resembles the current Presets. So when the user chooses Numbers under type we have a gid of predefined number options there. If it's bullets the grid shows this. And for characters it provides easy access to symbols. Ideally, the new number and bullet presets can be extended like the characters."

"Alternatively, we could also have a column left of levels that provides presets as known from the area fill dialog. We ship a couple of presets and the user can extend it easily with what she configures."

Haven't checked back what's fixed meanwhile.
Comment 14 Mike Kaganski 2019-07-22 19:39:26 UTC
(In reply to Heiko Tietze from comment #13)
> Commented on https://gerrit.libreoffice.org/#/c/71944/:
> 
> * We merged the alignment into the fine-tuning - so it comes after color and
> does not occupy extra space somewhere else.

... which was a mistake; please see bug 120905 comment 11 and following discussion.
Comment 15 Commit Notification 2019-07-30 16:04:40 UTC
Gülşah Köse committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/392fe03c2622a69c078adb9b993b5589e8b01d09%5E%21

tdf#125642 Fix layout issues for Bullet dialog.

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.