Bug Hunting Session
Bug 125711 - Large number of Comments (permanently) deleted, with record track changes enabled
Summary: Large number of Comments (permanently) deleted, with record track changes ena...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, dataLoss, regression
Depends on:
Blocks: Track-Changes Writer-Comments
  Show dependency treegraph
 
Reported: 2019-06-05 13:36 UTC by Telesto
Modified: 2019-06-06 07:22 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2019-06-05 13:36:32 UTC
Description:
Comments (permanently) deleted, with record changes enabled

Steps to Reproduce:
1. Open attachment 151939 [details]
2. Scroll down notice the comments on every page 
3. Check if record track changes is enabled (should be)
4. Select a the drop down button at a comment -> Delete a comments (wait)
5. Scroll down -> Scrolling is faster.. Yay.. Wait a minute.. there are lot less comments around

Actual Results:
Not all comments aren't tracked with record track changes enabled

Expected Results:
It probably should, or did I miss something?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 93477d1a963e38e3319013e43835a8ffef200972
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-02_10:16:52
Locale: it-IT (nl_NL); UI-Language: en-US
Calc: threaded
Comment 1 Timur 2019-06-05 14:23:04 UTC Comment hidden (obsolete)
Comment 2 Telesto 2019-06-05 14:58:28 UTC Comment hidden (obsolete)
Comment 3 Telesto 2019-06-05 14:59:13 UTC
Sorry, yes, Delete All Comments

1. Open attachment 151939 [details]
2. Observe that there are comments on every page (by scrolling down) 
3. Check if record track changes is enabled (should be)
4. Select a the drop down button on a comments -> Delete all comments (wait)
5. Scroll down to the bottom -> Notice comments are missing [with the positive side effect that scrolling is rather smooth]
Comment 4 Dieter Praas 2019-06-05 16:51:54 UTC
I confirm it with

Version: 6.3.0.0.beta1 (x64)
Build ID: a187af327633f5f00363be5131bd21a13e0f1a7b
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (de_DE); UI-Language: en-GB
Calc: threaded

number of comments in original document: 1465
number of comments affected by track changes after delete all: 370
Comment 5 Telesto 2019-06-05 17:24:32 UTC
No repro with
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

@Dieter
Where can I see the number of comments
Comment 6 Dieter Praas 2019-06-05 17:45:32 UTC
(In reply to Telesto from comment #5)
> Where can I see the number of comments

Navigator => Tooltip if you click on "comments"
Comment 7 Timur 2019-06-06 07:14:04 UTC
Repro in LO 5.0. Also in Linux. 
When all comments are deleted, number shown in Navigator tooltip is first 5 then 370. Would be better if comment text was numbered.
Comment 8 Timur 2019-06-06 07:22:12 UTC
Doesn't seem like a real regression, rather incomplete fix. LO 4.4 first shows just 5 comments and later 1170 (and crashes). Could be related to comments handling (Bug 61558).