Bug Hunting Session
Bug 125740 - Karasa Jaga has the same icons for different buttons on the Track Changes toolbar
Summary: Karasa Jaga has the same icons for different buttons on the Track Changes too...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0 target:6.3.0.1
Keywords:
Depends on:
Blocks: Icon-Theme-KarasaJaga
  Show dependency treegraph
 
Reported: 2019-06-06 12:29 UTC by NISZ LibreOffice Team
Modified: 2019-06-12 10:13 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the problem in Writer (98.14 KB, image/png)
2019-06-06 12:29 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-06-06 12:29:52 UTC
Created attachment 151966 [details]
Screenshot of the problem in Writer

In the Karasa Jaga icon theme the Track Changes toolbar shows the same icons for the Accept Track Change and the Accept All Tracked Changes buttons; also the same ones for the Reject Track Change and the Reject All Tracked Changes buttons.


Steps to reproduce:
    1. Create a document with text
    2. Do two separate changes
    3. Enable View – Toolbars – Track Changes and look at the icons

Actual results:
Accept Track Change and the Accept All Tracked Changes buttons have the same icon.
Reject Track Change and the Reject All Tracked Changes also have the same one.

Expected results:
The Accept all / Reject all buttons have a unique icon. Maybe with double tick marks / X or the like, similarly to other icon themes.

LibreOffice details:
Version: 6.3.0.0.beta1+ (x86)
Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: threaded
Comment 1 Dieter Praas 2019-06-06 13:01:10 UTC
cc: Andreas Kainz
Comment 2 Roman Kuznetsov 2019-06-06 19:19:19 UTC
it isn't the same. Icons for all accept or reject have two pages, but yes it look not good for me too.

Rizal, may be better make two ✔ and ✘ symbols on icons for all accept/reject icons instead two pages? What do you think?
Comment 3 Commit Notification 2019-06-12 08:21:03 UTC
rizmut committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f8c6667a4407606a34917bba737bcb2578bcf2ca%5E%21

Karasa Jaga: tdf#125740; change accept all & reject all icons

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2019-06-12 10:13:20 UTC
rizmut committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/4d7d17be6c34ac439339bbf90b417fd6ff4c1161%5E%21

Karasa Jaga: tdf#125740; change accept all & reject all icons

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.