Bug 125742 - Colibre icons are misleading on the Track Changes toolbar
Summary: Colibre icons are misleading on the Track Changes toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:6.4.0 target:6.3.0.1
Keywords:
Depends on:
Blocks: Icon-Theme-Colibre
  Show dependency treegraph
 
Reported: 2019-06-06 12:47 UTC by NISZ LibreOffice Team
Modified: 2019-06-13 23:11 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot of the problem in Writer (77.78 KB, image/png)
2019-06-06 12:47 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-06-06 12:47:56 UTC
Created attachment 151971 [details]
Screenshot of the problem in Writer

With the Colibre icon theme similar functions on the Track Changes toolbar have very different icons, while distinct functions have similar icons, making the toolbar confusing.


Steps to reproduce:
    1. Create a document with text
    2. Do two separate changes
    3. Enable View – Toolbars – Track Changes and look at the icons

Actual results:
Accept Track Change button has a “green tick mark” icon, Accept All Tracked Changes button has “two blue tick mark on a document” icon.
Manage Track Changes button has “blue tick mark on a document” icon.
Reject Track Change and Reject All Tracked Changes buttons have similar icons: one and two red X marks on a document – that’s good!

Expected results:
Accept Track Change and Accept All Tracked Changes button should have similarly colored and styled icons, while Manage Track Changes button should have a more distinct one from these.
For reference there is no such problem with Breeze, Elementary, Sift and Tango.

LibreOffice details:
Version: 6.3.0.0.beta1+ (x86)
Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: threaded
Comment 1 Dieter 2019-06-06 13:00:02 UTC
cc: Andreas Kainz
Comment 2 Roman Kuznetsov 2019-06-06 19:13:56 UTC
I agree, need to rework it
Comment 3 Adolfo Jayme Barrientos 2019-06-13 05:40:59 UTC
Addressed with commit 47d0dac4f4b165a7e18a09aa45a6984a6c1fce0e (master) and 8f21ab1af35b789feef66032e8efdf8cbb88d8d2 (cherry-pick to 6-3).
Comment 4 Rizal Muttaqin 2019-06-13 07:40:05 UTC Comment hidden (off-topic)
Comment 5 Adolfo Jayme Barrientos 2019-06-13 23:11:22 UTC Comment hidden (off-topic)