Bug 125828 - XLSX: Performance issue undoing filtering file with 1500 comments in cells (GTK/GTK3)
Summary: XLSX: Performance issue undoing filtering file with 1500 comments in cells (G...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: filter:xlsx, perf, wantBacktrace
Depends on:
Blocks: Undo-Redo XLSX-Autofilter
  Show dependency tree / graph
 
Reported: 2019-06-10 12:41 UTC by Xisco Faulí
Modified: 2019-08-09 11:39 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2019-06-10 12:41:13 UTC 
Steps to reproduce:
1. Open attachment 144598 [details] from bug 119637
2. Filter Column A selecting only 'asf' -> it takes ~6 seconds ( reported in bug 119637 )
3. Undo

Observed behaviour: it takes 1 minute 20 seconds

Reproduced in

Version: 6.4.0.0.alpha0+
Build ID: 43ddddb703bcdb9430752af63ae46527f737f874
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Xisco Faulí 2019-06-10 12:47:36 UTC 
it takes 5 seconds in

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

thus, it's a regression
Comment 2 Xisco Faulí 2019-06-10 12:59:41 UTC 
Actually this is not a regression, just reproducible in GTK/GTK3
Comment 3 Xisco Faulí 2019-06-10 13:01:40 UTC 
@Caolán, I thought you might be interested in this issue...
Comment 4 Caolán McNamara 2019-06-11 08:16:52 UTC 
I'm not seeing the evidence that its a GTK specific thing, there are an infinite number of issues and they cannot all become tagged GTK things
Comment 5 Roman Kuznetsov 2019-07-04 08:33:39 UTC 
don't repro in Windows build

Version: 6.4.0.0.alpha0+ (x86)
Build ID: d35171456bc230efdaa9426da1398b2db7fa0df8
CPU threads: 4; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-27_04:11:18
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: threaded

undoing takes only 1 sec
Comment 6 Xisco Faulí 2019-08-09 11:39:53 UTC 
it takes 8 seconds in

Version: 6.4.0.0.alpha0+
Build ID: d4a70ecf61b016a32caef015eea127d13b357cf7
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

(same timing with gtk2 )

I guess we can close this as RESOLVED WORKSFORME