Bug Hunting Session
Bug 125830 - Change Redaction toolbar
Summary: Change Redaction toolbar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.0.beta1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Redaction
  Show dependency treegraph
 
Reported: 2019-06-10 13:10 UTC by Roman Kuznetsov
Modified: 2019-08-24 22:52 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-06-10 13:10:52 UTC
Description:
Change Redaction toolbar. 
We have on Redaction toolbar unnecessary drop-down widget with only two tools now.
I suggest remove the widget and move two tools from it to main Redaction toolbar.
Also I suggest add to the toolbar icon for opening new Autoredaction dialog.

Steps to Reproduce:
-

Actual Results:
there is unnecessary drop-down widget on Redaction toolbar

Expected Results:
Redaction toolbar looks more simple and friendly


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Heiko Tietze 2019-06-11 10:30:44 UTC
Sounds reasonable - and much easier to customize. Muhammet, what do you think?
Comment 2 Muhammet Kara 2019-06-12 09:04:51 UTC
(In reply to Roman Kuznetsov from comment #0)
> Description:
> Change Redaction toolbar. 
> We have on Redaction toolbar unnecessary drop-down widget with only two
> tools now.
> I suggest remove the widget and move two tools from it to main Redaction
> toolbar.

Sounds reasonable.

> Also I suggest add to the toolbar icon for opening new Autoredaction dialog.

Let's omit this. Autoredaction dialog is still being baked, and this is not how it works.

> 
> Steps to Reproduce:
> -
> 
> Actual Results:
> there is unnecessary drop-down widget on Redaction toolbar
> 
> Expected Results:
> Redaction toolbar looks more simple and friendly
> 
> 
> Reproducible: Always
> 
> 
> User Profile Reset: No
> 
> 
> 
> Additional Info:
> -

(In reply to Heiko Tietze from comment #1)
> Sounds reasonable - and much easier to customize. Muhammet, what do you
> think?

Agreed.
Comment 3 BogdanB 2019-06-12 09:20:50 UTC
Muhammet Kara, do you agree that "Direct to PDF" should be rename to be as close as posible to the result we get? Maybe "Preview PDF"
Comment 4 Heiko Tietze 2019-06-12 14:08:07 UTC
(In reply to BogdanB from comment #3)
> Muhammet Kara, do you agree that "Direct to PDF" should be rename to be as
> close as posible to the result we get? Maybe "Preview PDF"

Please file a new ticket. But I would say "Direct to PDF" has become a standard term. 

For the change all +1, so removing needsUX.
Comment 5 Thomas Lendo 2019-08-13 11:24:29 UTC
(In reply to BogdanB from comment #3)
> Muhammet Kara, do you agree that "Direct to PDF" should be rename to be as
> close as posible to the result we get? Maybe "Preview PDF"
I support Heiko's comment 4 that the naming shouldn't be changed. Besides that "preview" is the false term for this as a new pdf file will be produces which is another matter than a preview (page view) like in Calc or Writer.
Comment 6 BogdanB 2019-08-13 18:14:32 UTC
(In reply to Thomas Lendo from comment #5)
> (In reply to BogdanB from comment #3)
> > Muhammet Kara, do you agree that "Direct to PDF" should be rename to be as
> > close as posible to the result we get? Maybe "Preview PDF"
> I support Heiko's comment 4 that the naming shouldn't be changed. Besides
> that "preview" is the false term for this as a new pdf file will be produces
> which is another matter than a preview (page view) like in Calc or Writer.

Ok.
Comment 7 Thomas Lendo 2019-08-14 10:20:37 UTC
(In reply to Muhammet Kara from comment #2)
> (In reply to Roman Kuznetsov from comment #0)
> > Description:
> > Change Redaction toolbar. 
> > We have on Redaction toolbar unnecessary drop-down widget with only two
> > tools now.
> > I suggest remove the widget and move two tools from it to main Redaction
> > toolbar.
> Sounds reasonable.
Is the default behavior visible for the user with an 'activated state' of the relevant button? I'm afraid if the user can be confused about the different behavior in the toolbar: There are single click buttons that make an action possible or an action follows. And there are buttons that change the visibility of redaction feature without further action. To separate them, the sub-menu widget was a good idea. But I also see that in such a small toolbar this looks a little bit excessive.
Comment 8 Pedro 2019-08-23 15:44:08 UTC
(In reply to BogdanB from comment #3)
> Muhammet Kara, do you agree that "Direct to PDF" should be rename to be as
> close as posible to the result we get? Maybe "Preview PDF"

There are multiple complaints in reviews of the Redaction toolbar about having the "Direct to PDF" button exporting documents with 50% transparency on the redaction bars. Namely on Arstchenica review of 6.3 and on Dedoimedo's review.

https://www.dedoimedo.com/computers/libreoffice-6-3-review.html

 "The one thing that baffles me is that default redaction comes at 50% transparency, so you actually need to change that before you blank the text. But then I'm still wondering how effective this really is, because the actual text still exists, and it's only hidden behind a layer of color. All in all, it works, but there should be more magic to it."

Proposals:

1 - Change the "Export Directly as PDF" to export already completely redacted with the black bars and not 50% transparent bars. In essence what the "Redacted Export (black)" does currently. Change the current "Export Directly as PDF" to the drop-down button and name it Preview Export.

2 - Rename the "Export Directly as PDF" to "Export Preview PDF". This is to address Thomas Lendo rationale that naming the button "Preview" and having a different preview action than in Calc or Writer is a problem.
By naming it "Export Preview PDF" the user knows that they are not exporting a final redacted version (I would also include a tooltip mentioning that this export, the redaction boxes have 50% transparency).

I would prefer option 1.
Comment 9 Thomas Lendo 2019-08-23 16:55:49 UTC
Pedro, as there should be one bug per issue there is another bug for the 50% issue: Bug 126915 - Redaction object opacity is not 100%
Comment 10 Thomas Lendo 2019-08-24 22:52:43 UTC
What is the reason for the button 'Export Directly as PDF' in relation to the other two export commands?