Bug 125905 (Regressions-705a8c22) - [META] DOC: Regressions introduced by 705a8c226aee3e68db492083b7cf8b704335328b
Summary: [META] DOC: Regressions introduced by 705a8c226aee3e68db492083b7cf8b704335328b
Status: NEW
Alias: Regressions-705a8c22
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on: 103967 104027 106705 114629 119803 125602 102334 104616 111802 116427
Blocks:
  Show dependency treegraph
 
Reported: 2019-06-13 16:39 UTC by Xisco Faulí
Modified: 2020-07-16 09:05 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Xisco Faulí 2019-06-13 16:44:53 UTC
https://bugs.documentfoundation.org/show_bug.cgi?id=103967#c11 gives a hint on how to fix it, however, more works needs to be done as it would break the unittest for bug 117923. I gave a try at https://gerrit.libreoffice.org/#/c/73834/ but it doesn't fix the root cause, it just makes the unitests pass.
Comment 2 Justin L 2020-07-16 08:22:24 UTC
In order to easily test for this regression with linux bibisect-44max:

first bad bibisect commit bdd0a608f23b1c4e54e3ec396e888cd40e2afa6f

    source commit 705a8c226aee3e68db492083b7cf8b704335328b
    Author:     Caolán McNamara on Wed Sep 24 10:04:48 2014 +0100
    
WW8PLCFMan::AdjustEnds deeply flawed concept wrt change tracking
    
The whole idea of clipping the char attributes to before the cr that word uses
as the end of para marker is flawed from especially the perspective of
redlining which is a char property in word.

If the redline encompasses the newline in order to state that it is deleted,
then if the prop is clipped to before that newline then the end-of-para doesn't
get marked as deleted

For now just remove the character attributes clipping from here to be as
conservative as possible.

Hopefully the ordering of processing start pap before start chp and end chp
before end pap and the other million improvements in the parser that came about
after AdjustEnds was created avoids whatever problems were trying to be worked
around here.
Change-Id: I5a72e462db2fff60f52b12c2125ea6ac363de695

===============================

first good bibisect commit 30f5a584d5dcd60adfbfd897305f47cd8f71961c
    source commit 6332c643016ce4c4d254c8429a5eceae6664bf5c
    Author:     Samuel Mehrbrodt on Wed Sep 24 10:38:26 2014 +0200

    fdo#83955 Fix changes toolbar to display icons+text
Comment 3 Caolán McNamara 2020-07-16 09:02:42 UTC
feel free to revert it
Comment 4 Justin L 2020-07-16 09:05:39 UTC
(In reply to Caolán McNamara from comment #3)
> feel free to revert it

Who would want their name on that patch :-)
We'd probably just get another meta-bug :-(