Bug Hunting Session
Bug 125908 - Enhancement request: Backport 6.3 FILESAVE dialog to 6.2
Summary: Enhancement request: Backport 6.3 FILESAVE dialog to 6.2
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.0.0.1 rc
Hardware: All Linux (All)
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-13 20:48 UTC by Roy Reese
Modified: 2019-06-15 15:18 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
LO-6.2.4.2 save (as) dialog in installed E22 (50.37 KB, image/jpeg)
2019-06-13 20:48 UTC, Roy Reese
Details
LO-6.3-beta1 save dialog installed on Mageia 7 with E22 (60.93 KB, image/jpeg)
2019-06-13 20:49 UTC, Roy Reese
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Reese 2019-06-13 20:48:03 UTC
Created attachment 152174 [details]
LO-6.2.4.2 save (as) dialog in installed E22

The current file save dialog for the Linux Enlightenment desktop makes it difficult to save to externally connected devices. Although separate partitions and devices can be added to locations, this is still disfunctional for devices that will not be connected regularly.

The 6.2.4.2 and 6.3 dialogs are shown in attachments; a test of 6.2.4.2 for a live version of Plasma showed a similar dialog, while XFCE, Cinnamon and Mate dialogs are closer to the 6.3 dialog.
Comment 1 Roy Reese 2019-06-13 20:49:13 UTC
Created attachment 152175 [details]
LO-6.3-beta1 save dialog installed on Mageia 7 with E22
Comment 2 Michael Weghorn 2019-06-14 06:19:08 UTC
Different file dialogs are used for different so-called "VCL plugins" (desktop integrations).
Can you please paste the version information from "About" -> "LibreOffice" for both scenarios?

The attached screenshot for 6.3 shows the gtk3 file dialog, while I don't know what the other one is (looks a bit like the non-native qt5 one for me, but not the same).

6.2 has the same file dialog for gtk3 already, so it might be that you are just missing the relevant package that provides the gtk3/GNOME integration (I think the package is called libobasis6.2-gnome-integration if you're using the TDF provided packages).
It might also be that this is a native file dialog provided by the desktop environment.

As far as kde5/Plasma is concerned, external devices are shown there from the upcoming LibreOffice version 6.2.5 on, s. bug 123750.
Comment 3 Heiko Tietze 2019-06-14 06:26:10 UTC
At Tools > Options look for LibreOffice > General > Use LibreOffice Dialogs when LibreOffice > Advanced > Enable Experimental features is checked.

Basically we aim for being close to the OS/DE and want to retire the inbuilt dialogs due to usability issues (it was just a workaround at KDE4 times).
Comment 4 Roy Reese 2019-06-14 11:17:08 UTC
(In reply to Michael Weghorn from comment #2)
> Different file dialogs are used for different so-called "VCL plugins"
> (desktop integrations).
> Can you please paste the version information from "About" -> "LibreOffice"
> for both scenarios?
Oops, actually running 6.2.3.2:
Versión: 6.2.3.2
Id. de compilación: 6.2.3.2-3.mga7
Subprocs. CPU: 4; SO: Linux 5.1; Repres. IU: predet.; VCL: gtk3; 
Configuración regional: es-ES (es_ES.UTF-8); Idioma de IU: es-ES
Calc: threaded
(Versión sumistrada por Mageia)

Versión: 6.3.0.0.beta1
Id. de compilación: a187af327633f5f00363be5131bd21a13e0f1a7b
Subprocs. CPU: 4; SO: Linux 5.1; Repres. IU: predet.; VCL: gtk3; 
Configuración regional: es-ES (es_ES.UTF-8); Idioma de IU: es-ES
Calc: threaded
(Versión sumistrada por The Document Foundation(

> 6.2 has the same file dialog for gtk3 already, so it might be that you are
> just missing the relevant package that provides the gtk3/GNOME integration
> (I think the package is called libobasis6.2-gnome-integration if you're
> using the TDF provided packages).
I have installed the following package for GTK3 integration: 
        libreoffice-gtk3-6.2.3.2-3.mga7
which provides the following files:
        /usr/lib/.build-id
‎        /usr/lib/.build-id/de
‎        /usr/lib/.build-id/de/6bb85e6714b2c6143eec7467075fa7fe2fe4cf
‎        /usr/lib64/libreoffice/program/gtk3.abignore
‎        /usr/lib64/libreoffice/program/libvclplug_gtk3lo.so
Comment 5 Roy Reese 2019-06-14 11:21:49 UTC
(In reply to Heiko Tietze from comment #3)
> At Tools > Options look for LibreOffice > General > Use LibreOffice Dialogs
> when LibreOffice > Advanced > Enable Experimental features is checked.
Just check this and restarted, but the save dialog remains the same . . . .
Comment 6 Heiko Tietze 2019-06-14 12:09:34 UTC
There is the inbuilt file dialog, with bad usability, and there is the native dialog. You can switch it on/off when the experimental mode is active. What you eventually get as internal dialog depends on the desktop environment and on the VCL plugin (KDE5, GTK2/3, GEN...). 

Nevertheless we should make sure that the default is the system dialog.
Comment 7 Cor Nouws 2019-06-14 13:48:55 UTC
(In reply to Heiko Tietze from comment #6)
> There is the inbuilt file dialog, with bad usability, and there is the

The internal LibreOffice file dialog is easier and more reliable in use with keyboard than the Gnome one on my OS.

> native dialog. You can switch it on/off when the experimental mode is
> active. What you eventually get as internal dialog depends on the desktop
> environment and on the VCL plugin (KDE5, GTK2/3, GEN...). 
> 
> Nevertheless we should make sure that the default is the system dialog.
OK, but also bring back the setting from Expert (*) to General
 Options > LibreOffice > Advanced > Expert config. .. search for dialog,
or better UseSystemFileDialog.
Comment 8 Roy Reese 2019-06-14 18:07:49 UTC
(In reply to Cor Nouws from comment #7)
> > Nevertheless we should make sure that the default is the system dialog.
> OK, but also bring back the setting from Expert (*) to General
>  Options > LibreOffice > Advanced > Expert config. .. search for dialog,
> or better UseSystemFileDialog.
Perfect, Cor. I did not dig deeply enough on Heiko's comment, but giving me the variable did the job.

Moreover, the difference between LO-6.2.3.2 and 6.3.0.0-beta1 is precisely that UseSystemFileDialog is set by default to false in the former and true in the latter.

Perhaps the devs will see that it defaults set to true in the LO-6.2.5.x release?
Comment 9 Michael Weghorn 2019-06-15 07:58:37 UTC
(In reply to Cor Nouws from comment #7)
> (In reply to Heiko Tietze from comment #6)
> > There is the inbuilt file dialog, with bad usability, and there is the
> 
> The internal LibreOffice file dialog is easier and more reliable in use with
> keyboard than the Gnome one on my OS.

I'd suggest to try to get this improved.
If this a LibreOffice-only problem (i.e. it works fine with other GNOME/Gtk applications like gedit), a separate bug report should be filed here in Bugzilla IMHO. Otherwise an issue should be reported in GNOME's issue tracker.

> 
> > native dialog. You can switch it on/off when the experimental mode is
> > active. What you eventually get as internal dialog depends on the desktop
> > environment and on the VCL plugin (KDE5, GTK2/3, GEN...). 
> > 
> > Nevertheless we should make sure that the default is the system dialog.
> OK, but also bring back the setting from Expert (*) to General
>  Options > LibreOffice > Advanced > Expert config. .. search for dialog,
> or better UseSystemFileDialog.

I suggest to keep the original scope of this bug report. There is already bug 114484 which seems to be the better place for discussing this.(In reply to Roy Reese from comment #8)


> (In reply to Cor Nouws from comment #7)
> Perhaps the devs will see that it defaults set to true in the LO-6.2.5.x
> release?

I quickly checked and it defaults to true in my case for LibreOffice 6.2 as well. Maybe it was explicitly set to false in your case previously?
Can you check what happens if you test with a clean user profile?
Comment 10 Cor Nouws 2019-06-15 15:18:03 UTC
(In reply to Michael Weghorn from comment #9)
 
> I suggest to keep the original scope of this bug report.
Well, let me then close as NotABug.. Attachment 152174 [details] is the internal van Attachment 152175 [details] the desktop file dialog. So there is no bug.

> There is already bug 114484 which seems to be the better place for 
> discussing this.(In reply to Roy Reese from comment #8)
I took the freedom to combat the hiding of the option to activate the use of the internal file dialog, I was triggered by a mail on the users-list and my own experience. But - fair is fair - it's not what this issue was about :)