Bug 126036 - Inconsistent arrangement of dialog buttons (and inconsistency in availability of certain buttons)
Summary: Inconsistent arrangement of dialog buttons (and inconsistency in availability...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:6.3.0.1 target:6.4.0 target:6.2.6
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2019-06-21 09:18 UTC by Telesto
Modified: 2019-07-19 11:32 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshots (50.75 KB, application/pdf)
2019-06-21 09:19 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2019-06-21 09:18:38 UTC
Description:
1. Inconsistent arrangement of dialog buttons. 
2. Inconsistent availability  of certain buttons

-> Some dialogs have a REST button others don't (without a proper reason). Why is the Page Style dialog lacking a RESET button?  
-> Why does the TABLE Properties dialog lacking a APPLY button (Page Style)

Steps to Reproduce:
Open the different dialogs (see attachment) and compare the arrangement.. Quite some difference between dialogs.. Be consistent (harmonic)


Actual Results:
Unharmonic, inconsistent (confusing)

Expected Results:
Consistency..


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 60271c4433372097ef5ecc74e522532ebf5af8e0
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-19_05:53:39
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded
Comment 1 Telesto 2019-06-21 09:19:14 UTC
Created attachment 152331 [details]
Screenshots
Comment 2 Heiko Tietze 2019-06-21 15:29:03 UTC
While some of the buttons are placed according the OS (Cancel or Okay right-most) the other buttons should have a consistent order. There is also bug 99104 about label alignment that should go into a HIG for dialog layout.
Comment 3 Caolán McNamara 2019-06-21 20:57:30 UTC
The page style dialog missing "reset" is a bug, so I'll take this bug to fix that specific problem at least.
Comment 4 Commit Notification 2019-06-22 17:28:10 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/ac9715d5f83843c1bb6004e50e1ce812971acbdd%5E%21

Related: tdf#126036 missing "reset" button

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2019-06-22 17:28:22 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/8e0b55bc9b788d2ac95768af6b9e88996dc10d29%5E%21

Related: tdf#126036 missing "reset" button

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-06-22 17:29:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/01cd1d68d96057624db38b9baaa6c6795353758d%5E%21

Related: tdf#126036 sort button by native order for async dialogs too

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-06-22 17:29:57 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/4cbf5a4f666ac4d7b01746bc36ab01400e28ff40%5E%21

Related: tdf#126036 sort button by native order for async dialogs too

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2019-06-22 19:39:54 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/38f1412294e7d2987072a2e211e1f68c197f16fa%5E%21

Related: tdf#126036 give options dialog consistent button order

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2019-06-22 19:46:39 UTC
a) page style dialog now has 'reset' back
b) insert section should be consistent in ordering with everything else
c) options dialog should be consistent in ordering with everything else
d) table properties is unchanged, no idea whether it should have an 'apply' or not. It never did though FWIW. Possibly there's scope for an additional feature request bug for that if someone else wants to follow that up
Comment 10 Commit Notification 2019-06-23 17:04:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-2":

https://git.libreoffice.org/core/+/ad8207d648d480790b5b1f6974b61020813cb92e%5E%21

Related: tdf#126036 missing "reset" button

It will be available in 6.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2019-06-23 17:40:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/1afa9f0f6cdcf11beb86e93529c7674a79af6771%5E%21

Related: tdf#126036 give options dialog consistent button order

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.