Download it now!
Bug 126102 - inserting signature line cannot be undone with Ctrl+Z
Summary: inserting signature line cannot be undone with Ctrl+Z
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Digital-Signature-Lines
  Show dependency treegraph
 
Reported: 2019-06-26 06:29 UTC by artur
Modified: 2019-07-03 12:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screencast (1.82 MB, video/ogg)
2019-06-27 03:34 UTC, artur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description artur 2019-06-26 06:29:15 UTC
1. Insert -> Signature Line
2. give the information
3. click "OK"
4. press Ctrl+Z or Edit -> Undo

expected: signature line disappears again
actual: Edit -> Undo says: "Change object description of SVG", Ctrl+Z has no visible effect

Version: 6.4.0.0.alpha0+
Build ID: c05753d5663a9241ddca6db8da5bfdb35b6c9739
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Xisco Faulí 2019-06-26 10:49:33 UTC
I can't reproduce it in

Version: 6.4.0.0.alpha0+
Build ID: fe855eda54faf6196ad9dea12d8dc090b6d6c1da
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

Are you using a local build? I can't find your commit c05753d5663a9241ddca6db8da5bfdb35b6c9739

To be certain the reported issue is not
related to corruption in the user profile, could you please reset your
Libreoffice profile ( https://wiki.documentfoundation.org/UserProfile ) and
re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present
Comment 2 artur 2019-06-27 03:34:30 UTC
Created attachment 152436 [details]
screencast
Comment 3 artur 2019-06-27 03:39:46 UTC
Sorry, I've been on an separate branch, but that had no functional changes, only tests added.
Recompiled again from master and same situation

Version: 6.4.0.0.alpha0+
Build ID: 62908055af3b0d75ed679818a51f7480de8b9800
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

also `--safe-mode` or deleting the user profile from /home/artur/.config/libreoffice/ does not do any difference

I've provided a screenrecording
Comment 4 QA Administrators 2019-06-28 03:00:37 UTC Comment hidden (obsolete)
Comment 5 Xavier Van Wijmeersch 2019-06-28 17:47:14 UTC
I can reproduce the problem with

Version: 6.4.0.0.alpha0+
Build ID: f19d3dda6b6a22d0894ec29e995f15a18b15aecc
CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk2; 
Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 6 Xisco Faulí 2019-07-03 11:35:57 UTC
(In reply to Xavier Van Wijmeersch from comment #5)
> I can reproduce the problem with
> 
> Version: 6.4.0.0.alpha0+
> Build ID: f19d3dda6b6a22d0894ec29e995f15a18b15aecc
> CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk2; 
> Locale: nl-BE (en_US.UTF-8); UI-Language: en-US
> Calc: threaded

I've just tried with gtk2

Version: 6.4.0.0.alpha0+
Build ID: 3cdc1b35b9d86bcfa1277e3e94925ae7b18b8fde
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

and the behaviour is still fine
Comment 7 Xisco Faulí 2019-07-03 11:38:58 UTC
Damn, how stupid I'm... I was testing it on writer, not calc...
Reproduced in

Version: 6.4.0.0.alpha0+
Build ID: 3cdc1b35b9d86bcfa1277e3e94925ae7b18b8fde
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk2; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 8 Xisco Faulí 2019-07-03 12:39:23 UTC
The feature was added in https://cgit.freedesktop.org/libreoffice/core/commit/?id=9891fd076c30d353e9edfee9678f0b8e96d26238

@Samuel Mehrbrodt, I thought you might be interested in this issue...