Bug 126112 - UI Images inserted in LibreOffice Writer document are not visible as hyperlink targets (gen)
Summary: UI Images inserted in LibreOffice Writer document are not visible as hyperlin...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.4.0 target:6.3.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Hyperlink
  Show dependency treegraph
 
Reported: 2019-06-26 13:44 UTC by NISZ LibreOffice Team
Modified: 2019-06-27 11:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer (26.54 KB, application/vnd.oasis.opendocument.text)
2019-06-26 13:44 UTC, NISZ LibreOffice Team
Details
Example file from Calc (6.82 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-06-26 13:47 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem in Writer (203.20 KB, image/png)
2019-06-26 13:47 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem in Calc (113.73 KB, image/png)
2019-06-26 13:48 UTC, NISZ LibreOffice Team
Details
Screenshot of the window in Writer 6.1.4.2.0+ (186.74 KB, image/png)
2019-06-26 13:53 UTC, NISZ LibreOffice Team
Details
Screenshot of the window in Calc 6.1.4.2.0+ (150.12 KB, image/png)
2019-06-26 13:54 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-06-26 13:44:16 UTC
Created attachment 152418 [details]
Example file from Writer

Images inserted in LibreOffice Writer document are not visible as hyperlink targets.

Steps to reproduce:
    1. Create a New document in LibreOffice Writer.
    2. Insert two images.
    3. Select an image and press CTRL+K.
    4. Select Document and click on icon below Target in Document.
    5. Notice that inserted images aren’t listed in Target in Document window.

Actual results:
There aren’t listed images in Target in Document window.

Expected results:
The inserted images should be listed in Target in Document window.

LibreOffice details:
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 719f4a93e46a6b397356dbb605d2867639ca3942
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-06-26_00:42:52
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

Similar case in Calc:

Sheets inserted in LibreOffice Calc are not visible as hyperlink targets.

Steps to reproduce:
    1. Create a new Spreadsheet in LibreOffice Calc
    2. Insert a new sheet
    3. Press CTRL+K
    4. Select Document and click on icon below Target in Document.
    5. Notice that inserted sheets aren’t listed in Target in Document window.

Actual results:
There aren’t listed sheets in Target in Document window.

Expected results:
The inserted sheets should be listed in Target in Document window.
Comment 1 NISZ LibreOffice Team 2019-06-26 13:45:26 UTC
Bibisected using bibisect-win64-6.4 to: 
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=30b4f468b04d48e3fa734780028079a351b73306
author: 	Caolán McNamara <caolanm@redhat.com>	2019-06-17 09:10:50 +0100
committer: Caolán McNamara <caolanm@redhat.com>	2019-06-17 12:34:23 +0200
summary: weld SvxHlinkDlgMarkWnd

Adding CC to: Caolán McNamara
Comment 2 NISZ LibreOffice Team 2019-06-26 13:47:06 UTC
Created attachment 152419 [details]
Example file from Calc
Comment 3 NISZ LibreOffice Team 2019-06-26 13:47:31 UTC
Created attachment 152420 [details]
Screenshot of the problem in Writer
Comment 4 NISZ LibreOffice Team 2019-06-26 13:48:08 UTC
Created attachment 152421 [details]
Screenshot of the problem in Calc
Comment 5 NISZ LibreOffice Team 2019-06-26 13:53:45 UTC
Created attachment 152422 [details]
Screenshot of the window in Writer 6.1.4.2.0+
Comment 6 NISZ LibreOffice Team 2019-06-26 13:54:24 UTC
Created attachment 152423 [details]
Screenshot of the window in Calc 6.1.4.2.0+
Comment 7 Xisco Faulí 2019-06-26 15:27:13 UTC
I can't reproduce it in

Version: 6.4.0.0.alpha0+
Build ID: ea19b0c0230fcc730245ecd445c03164cb6a1d18
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

but I do in


Version: 6.4.0.0.alpha0+
Build ID: ea19b0c0230fcc730245ecd445c03164cb6a1d18
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded
Comment 8 Caolán McNamara 2019-06-26 20:24:24 UTC
Does https://gerrit.libreoffice.org/#/c/74758/ fix this ?
Comment 9 Commit Notification 2019-06-27 07:56:47 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/0bbefaebc45a18dfe460de1b3e7bce61fd2bc9c7%5E%21

tdf#126112 expander missing

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2019-06-27 07:58:28 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/8e4814cfc4b77f0e796ecfeadabd33d84a362cbb%5E%21

tdf#126112 expander missing

It will be available in 6.3.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Xisco Faulí 2019-06-27 11:15:31 UTC
Verified in

Version: 6.4.0.0.alpha0+
Build ID: a294457eb95e60028539b6783abac78b56561fe2
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; 
Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!!