Insert an image into a document, then try to add an Image map (make parts of the image hyperlinks). The menu positions for this vary: Writer: Edit->ImageMap Writer/Web: Edit->ImageMap Writer/Forms: Edit->ImageMap Calc: Edit->ImageMap Draw: Tools->ImageMap Impress: Tools->ImageMap This should be unified.
Hi Samuel, Reproduced with LO 6.4.0.0.alpha0+ (x86) Build ID: 719f4a93e46a6b397356dbb605d2867639ca3942 CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; Locale: fr-FR (fr_FR); UI-Language: en-US Calc: CL but not with LO 6.2.0.0.alpha0+ Build ID: 1aa37aa6bee19099b57555a6d839992b054aa405 CPU threads: 2; OS: Windows 6.1; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2018-09-23_10:17:54 Locale: fr-FR (fr_FR); Calc: threaded where I found Edit > ImageMap in Draw and Impress. Jacques
I moved ImageMap in Draw and Impress in the Tools section. Here is the patch https://gerrit.libreoffice.org/#/c/70299/ And discussion was done in Bug 124198 should I move ImageMap in sd and sc modules to?
(In reply to andreas_k from comment #2) > I moved ImageMap in Draw and Impress in the Tools section. > > Here is the patch https://gerrit.libreoffice.org/#/c/70299/ > And discussion was done in Bug 124198 > > should I move ImageMap in sd and sc modules to? I think you meant sw and sc modules, but yes--moved consistently to under the Tools menu where the sd module already has it active for whole frame or for selected images in Draw & Impress. But it will need help article updates as well, similar to as was done with https://gerrit.libreoffice.org/#/c/71397/
+1 for all under Tools
but in which section in Tools at calc and writer?
(In reply to andreas_k from comment #5) > but in which section in Tools at calc and writer? Either both at the second section (after Redact) or as an extra section.
andreas kainz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/c738be4de6886a0c96b7d10df7e78c8b2964c135%5E%21 tdf:126142 ImageMap menubar entry moved to tools section It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
help need to be updated
Removing regression keyword since it's a documentation issue now
@Andreas, @Heiko, should the commit be backported to 6-3 branch ?
I don't think an backport is needed. cause in writer/calc it's the old position and in impress/draw the new one.
(In reply to andreas_k from comment #11) > I don't think an backport is needed. Agree
Then we maybe should revert the original patch in 6.3 so that it is consistent?
Maybe it is irrelevant, but the motivation of the original bug 124198: "As you don't have to select an Image ImageMap didn't have to be in Menubar -> Edit." From my Help patch commit msg: "Note that in Writer and Calc, ImageMap remains under Edit, because it is only enabled when an image is selected."
(In reply to Samuel Mehrbrodt (CIB) from comment #0) > Insert an image into a document, then try to add an Image map (make parts of > the image hyperlinks). > > The menu positions for this vary: > Writer: Edit->ImageMap > Writer/Web: Edit->ImageMap > Writer/Forms: Edit->ImageMap > Calc: Edit->ImageMap > Draw: Tools->ImageMap > Impress: Tools->ImageMap > > This should be unified. Getting back to this and referring to my earlier comment, the position of the menu items as listed by Samuel is logical and should not "be unified". Samuel: can you comment on this? Do you agree with my assessment and Andreas's original rationale and retract this request for unification?
Stuart and Heiko: do you continue to argue for a unified menu location even though the behaviour of the function is different depending on the application? I've had this report sitting in a browser tab for a year and it is starting to bother me. I think the commit in comment 7 went in too quickly and now we are dealing with a conflict of the help and the menu situation. Any change now will only appear in version 7.1, so we will have had two major versions with the conflict. I would revert the commit from comment 7.
(In reply to Buovjaga from comment #16) > do you continue to argue for a unified menu location... I'm split. You have good arguments but consistency has it's value too. ImageMaps to Edit in all modules? Seems wrong to me since the IM is more like an extra module than a function. Wouldn't it be the same for the Color Replacer, for example?
I would prefer to keep it in Tools to. Is there a reason for the different behavior in Writer? Maybe it can be enabled independent of the current selection too?
(In reply to Heiko Tietze from comment #17) > (In reply to Buovjaga from comment #16) > > do you continue to argue for a unified menu location... > > I'm split. You have good arguments but consistency has it's value too. > ImageMaps to Edit in all modules? Seems wrong to me since the IM is more > like an extra module than a function. Wouldn't it be the same for the Color > Replacer, for example? Maybe you were talking to yourself when saying "ImageMaps to Edit in all modules", but that is not what I was referring to. I was saying that Andreas's reasoning and change in bug 124198 was logical. ImageMap should be in Edit menu, *when it makes sense* and in Tools menu likewise. It doesn't make sense to have it in Tools menu in the context of Writer and Calc, because Writer and Calc need a selection before the tool is active. Anyway, maybe you disagree, but all I want is a closure to this, so I can either adjust the Help again or not adjust the Help. It's been a year.
(In reply to Buovjaga from comment #16) > Stuart and Heiko: do you continue to argue for a unified menu location even > though the behaviour of the function is different depending on the > application? > > I've had this report sitting in a browser tab for a year and it is starting > to bother me. I think the commit in comment 7 went in too quickly and now we > are dealing with a conflict of the help and the menu situation. Any change > now will only appear in version 7.1, so we will have had two major versions > with the conflict. > > I would revert the commit from comment 7. IMHO I would not. Instead finish the Help & User guide content. When creating or modifying an Image Map -- the dialog is still required when working with Image Maps => that makes it a Tool and it is correctly placed on the 'Tools' menu. So, not following the issue. We've moved the .uno:ImageMapDialog to the 'Tools' menu for all modules. As started for bug 124198 with https://gerrit.libreoffice.org/c/core/+/70299/ and finished here comment 7 with https://gerrit.libreoffice.org/c/core/+/75687/ Help was adjusted for the first with https://gerrit.libreoffice.org/c/help/+/71397/ Help remains to be finished to fully document the ImageMap "tool" and work flow.
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/0485136e4e45578bf086bcf98894c20e270c27dc tdf#126142 Update ImageMap menu item locations