Bug 126239 - Option “Sidebar icon size” has no Effect on Several Icons of the Sidebar
Summary: Option “Sidebar icon size” has no Effect on Several Icons of the Sidebar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
: 130554 136023 141480 153577 (view as bug list)
Depends on:
Blocks: Sidebar-UI-UX Icon-Themes-Code
  Show dependency treegraph
 
Reported: 2019-07-05 09:25 UTC by Harald Koester
Modified: 2023-10-04 09:48 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Koester 2019-07-05 09:25:38 UTC
The option “Sidebar icon size” has no effects on this sidebar icons in Writer:
(a) Icons of vertical bar: Sidebar Settings, Properties, Page, Styles, Gallery, Navigator
(b) Horizontal bar of panel Styles: Paragraph Styles, Character Styles, … Independent of the option “Sidebar icon size” these icons are always small.
(c) The icons “Icon View” and “Detailed View” in panel Gallery. Both are always large.
(d) Both horizontal bars of panel Navigator: Navigation, Previous Page, Next Page, … These icons are always small.

In order to reproduce the bug:
[1] Change option LibreOffice > View > Sidebar icon size to Small or to Large.
[2] Display the different panels of the sidebar.

Also in Calc, Impress and Draw the option has no effects on several icons.
Comment 1 V Stuart Foote 2019-07-31 12:55:06 UTC
Confirmed on Windows 10 Home 64-bit en-US (1903) with
Version: 6.2.5.2 (x64)
Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159
CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

and with recent master/6.4.0
Version: 6.4.0.0.alpha0+ (x86)
Build ID: 382aceb80d3c0f420d51762e1f88eee2334ff11b
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

Changes to the icon packing on shift between small/large icons would have greater visual impact on a HiDPI screen--that is, what is changed on toggle vs. what is affected on toggle, just some remaining too small. So agree the full Sidebar UI should respond (likewise the packing on the NB) which at 1920x1080 gets too tight with the large icons.

I did note in testing this that the on toggle to one or the other sizes--the icon for dialog call out of 'More Options' for its respective deck gets dropped. The button is still active, but dialog icon is gone.
Comment 2 V Stuart Foote 2019-07-31 13:29:55 UTC
> vs. what is affected on toggle, just some remaining too small...

s/affected/unaffected
Comment 3 Heiko Tietze 2019-08-01 06:48:57 UTC
Well, then let's treat this as a bug. The functionality small/large icons should be applied at all places.

Remark: I would questioning the icon size in general. Don't see a good use case, and if there is one we better provide dedicated icon sets.
Comment 4 V Stuart Foote 2019-08-01 13:50:05 UTC
(In reply to Heiko Tietze from comment #3)
> Well, then let's treat this as a bug. The functionality small/large icons
> should be applied at all places.

OK...

> 
> Remark: I would questioning the icon size in general. Don't see a good use
> case, and if there is one we better provide dedicated icon sets.

Well, going forward it would be useful for more than just applying the current small/large icon size toggle on the Sidebar.

Supporting enhancements like

-- using an extra large icon choice across the UI, like for just toolbars now
-- adjustable scale icons using SVG (HiDPI down through nominal 96dpi use), to return user scaling the UI (bug 101646)
-- apply fg/bg color to a monochromatic SVG icon theme (e.g. sifr)

So more than just consistent Automatic/user assignment of small/large/extra large the GUI needs a mechanism for controlling the full set of an active icon theme.
Comment 5 andreas_k 2020-10-02 05:59:16 UTC
in the property panel where most icons are, they use the size from the user setting.
Comment 6 Jean-Baptiste Faure 2021-04-14 17:29:45 UTC
*** Bug 141480 has been marked as a duplicate of this bug. ***
Comment 7 Jean-Baptiste Faure 2021-04-14 17:30:09 UTC
*** Bug 136023 has been marked as a duplicate of this bug. ***
Comment 8 Jean-Baptiste Faure 2021-04-14 17:32:05 UTC
*** Bug 130554 has been marked as a duplicate of this bug. ***
Comment 9 QA Administrators 2023-04-15 03:27:06 UTC Comment hidden (obsolete)
Comment 10 Kira Tubo 2023-09-23 04:49:13 UTC
Earliest I can reproduce is 5.3.0.0.alpha1. Prior to that, it looks like there wasn't an option to specifically adjust the sidebar icon size (only "Icon size and style" was available to be adjusted globally under Tools > Options > View). 

Issue is still reproducible with daily master build. 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 486ae5db6987411d5e394de94b2b077099d03856
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 11 Stéphane Guillou (stragu) 2023-10-04 09:31:26 UTC
*** Bug 153577 has been marked as a duplicate of this bug. ***
Comment 12 Stéphane Guillou (stragu) 2023-10-04 09:48:53 UTC
(In reply to Harald Koester from comment #0)
> (a) Icons of vertical bar: Sidebar Settings, Properties, Page, Styles,
> Gallery, Navigator

This is tracked separately in bug 90031, which is probably a good idea as it's outside the decks.

> (b) Horizontal bar of panel Styles: Paragraph Styles, Character Styles, …
> Independent of the option “Sidebar icon size” these icons are always small.
> (c) The icons “Icon View” and “Detailed View” in panel Gallery. Both are
> always large.
> (d) Both horizontal bars of panel Navigator: Navigation, Previous Page, Next
> Page, … These icons are always small.

All those are still valid in a recent trunk build.

(In reply to Kira Tubo from comment #10)
> Earliest I can reproduce is 5.3.0.0.alpha1. Prior to that, it looks like
> there wasn't an option to specifically adjust the sidebar icon size (only
> "Icon size and style" was available to be adjusted globally under Tools >
> Options > View). 

Thanks Kira, I can confirm that. As that was the first version that offered the option to specifically change the sidebar icon sizes, let's mark it as an "implementation error" rather than a regression.