Bug 126431 - Move Add/Edit/Delete buttons to right side in AutoRedact dialog
Summary: Move Add/Edit/Delete buttons to right side in AutoRedact dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.1 rc
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks: Redaction
  Show dependency treegraph
 
Reported: 2019-07-16 16:41 UTC by Roman Kuznetsov
Modified: 2019-09-05 12:08 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Buttons moving mockup (36.17 KB, image/jpeg)
2019-07-16 16:42 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-07-16 16:41:40 UTC
Description:
Move Add/Edit/Delete buttons to right side in AutoRedact dialog

Steps to Reproduce:
see mockup in attach

Actual Results:
Add/Edit/Delete buttons are in bottom of the dialog

Expected Results:
Add/Edit/Delete buttons are in right side of the dialog


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Roman Kuznetsov 2019-07-16 16:42:37 UTC
Created attachment 152816 [details]
Buttons moving mockup
Comment 2 Heiko Tietze 2019-07-17 04:04:33 UTC
Isn't it a duplicate to 126432?
Comment 3 Roman Kuznetsov 2019-07-17 05:04:39 UTC
(In reply to Heiko Tietze from comment #2)
> Isn't it a duplicate to 126432?

Muhammet asked make different bugs for all bugs/enh about AutoRedaction dialog
Comment 4 Heiko Tietze 2019-07-23 08:34:37 UTC
The dialog feels a bit heavy with the button wall at the right side. So I would go with keyboard (del, enter, etc.), context menu and, if needed, icon-only buttons.
Comment 5 Heiko Tietze 2019-07-25 12:26:57 UTC
No further input so let's do as suggested. My concerns are rather academically.
Comment 6 Muhammet Kara 2019-09-05 07:18:57 UTC
(In reply to Heiko Tietze from comment #4)
> The dialog feels a bit heavy with the button wall at the right side. So I
> would go with keyboard (del, enter, etc.), context menu and, if needed,
> icon-only buttons.

Might be nice additions. If you feel lile opening a/some enhancement requests for these, I would second that.

(In reply to Heiko Tietze from comment #5)
> No further input so let's do as suggested. My concerns are rather
> academically.

No objections. Thanks for the patch also! :)
Comment 7 Commit Notification 2019-09-05 09:06:50 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/9d52758d7db507948e1f70f8c6d47b05a1fdefb3%5E%21

Resolves tdf#126431 - Placement of buttons in AutoRedact dialog

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.