Bug 126827 - Disable Correct and Correct All buttons when spelling checking is finished
Summary: Disable Correct and Correct All buttons when spelling checking is finished
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:26.2.0
Keywords:
Depends on:
Blocks: Spell-Checking-Dialog
  Show dependency treegraph
 
Reported: 2019-08-11 16:22 UTC by Telesto
Modified: 2025-09-27 22:51 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2019-08-11 16:22:13 UTC
Description:
UI: Correct/ Correct all button not disabled when pressing Ignore once in the spelling dialog

Steps to Reproduce:
1. Open attachment 153297 [details]
2. Press F7
3. Press Ignore Once
4. Press OK for the spell check is complete
5. Press Correct button -> Nothing happens; button should be disabled IMHO

Actual Results:
Correct/ Correct button is enabled after spell check is complete dialog

Expected Results:
Buttons should be disabled?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.0.4 (x86)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Xisco Faulí 2020-01-23 12:30:44 UTC
I do confirm the issue

Versión: 6.4.0.2 (x86)
Id. de compilación: 08d19fecdc7a2298d051e19cfdb7c35544855fc3
Subprocs. CPU: 2; SO: Windows 6.1 Service Pack 1 Build 7601; Repres. IU: predet.; VCL: win; 
Configuración regional: es-ES (es_ES); Idioma de IU: es-ES
Calc: threaded

however, I'm adding the UX team to decide how LibreOffice should work
Comment 2 Heiko Tietze 2020-01-24 10:42:37 UTC
It's not "Ignore" or "Ignore once" but the end of checking that should trigger disabling of "Correct" and "Correct all"
Comment 3 QA Administrators 2022-08-24 03:45:04 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2024-08-24 03:15:55 UTC Comment hidden (obsolete, spam)
Comment 5 Justin L 2025-09-27 20:43:48 UTC
Already true for SentenceEditWindow_Impl::MarkNextError since introduced/moved
with commit d32b3a714fe55892bdead03502c5a9b0e77fa61d
Author: Mathias Bauer on Sat Oct 31 00:36:06 2009 +0100
    #i106421#: move svx/source/cui to cui

Looks safe to do. ModifyHdl is called a million times, and it re-enables those two if they are disabled.
Comment 6 Commit Notification 2025-09-27 22:48:35 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/33e85dfbd987b53181737ac678bfab039cdfd4cc

tdf#126827 cui SpellDialog: markNexterror - disable Correct buttons

It will be available in 26.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.