Bug 127296 - FILESAVE: DOC Rotated line loses rotation when saved
Summary: FILESAVE: DOC Rotated line loses rotation when saved
Status: RESOLVED DUPLICATE of bug 123321
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4.7.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:doc, regression
Depends on:
Blocks: DOC-Shapes
  Show dependency treegraph
 
Reported: 2019-09-02 18:59 UTC by Regina Henschel
Modified: 2021-07-20 09:31 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
File with rotated line, created by Word97 (21.00 KB, application/msword)
2019-09-02 18:59 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2019-09-02 18:59:59 UTC
Created attachment 153821 [details]
File with rotated line, created by Word97

Open attached document. It contains a line, which is vertical because it has been rotated. Save the document as .doc with a new name. Reopen the newly saved document. Notice that the line is now horizontal.

It is OK in Version: 5.1.6.1
Build ID: f3e25ec0581f5012f54d8810dcddd5824f4ee374
CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; 
Locale: de-DE (en_US); Calc: group

It is broken in Version: 5.4.7.2 (x64)
Build ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU threads: 8; OS: Windows 6.19; UI render: default; 
Locale: de-DE (en_US); Calc: CL

It is a "file save" error, because the document saved by 5.1.6.1 shows correct in 5.4.7.2. And the other way round, the document saved by 5.4.7.2 shows the missing rotation in 5.1.6.1 too.
Comment 1 MM 2019-09-02 19:59:03 UTC
Confirmed on mint 19.2 with Version: 6.4.0.0.alpha0+
Build ID: 41cd3e8e817c8c33a13608e62eeb06ce2c6977e4
CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-09-01_22:30:33
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Save to doc doesn't work correctly, but save to docx is also broken.
Comment 2 Aron Budea 2019-09-03 00:17:51 UTC
Let's keep this bug report about the DOC regression, the DOCX bug is a different issue (currently affected by bug 122717, and likely by bug 119121).

Bibisected the regression to the following commit using repo bibisect-linux-64-6.0. Adding Cc: to Szymon Kłos.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=d72e0cadceb0b43928a9b4f18d75c9d5d30afdda
author		Szymon Kłos <szymon.klos@collabora.com>	2017-06-19 15:32:16 +0200
committer	Andras Timar <andras.timar@collabora.com>	2017-06-28 22:38:49 +0200

Watermark: tdf#91687 correct size in the .doc
Comment 3 Aron Budea 2020-05-30 07:10:44 UTC
This briefly got fixed by Victor Mireyev's commit below, and then regressed again with Justin Luth's fix to a regression introduced by the first commit. Justin, do you have a thought on why this line might behave differently than other lines in other samples?
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c14911a80e3b6e66439b1d569e7cd558c6010864
author		Victor Mireyev <victor@opennodecloud.com>	2018-06-02 16:08:59 +0300
committer	Justin Luth <justin_luth@sil.org>	2018-06-16 06:49:56 +0200

tdf#70838 ww8export: rotate shape vertically = swap width/height

http://cgit.freedesktop.org/libreoffice/core/commit/?id=1cedd88d40a26a55ce433f8b742215aea83a5382
author		Justin Luth <justin_luth@sil.org>	2018-06-28 15:48:40 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2018-06-29 07:43:40 +0200

tdf#118421 ww8export: rotate vertically: not Lines or groups
Comment 4 Justin L 2020-05-30 08:18:07 UTC
Shapes and positioning is an area I probably should not have touched. I have no valuable thoughts. My only thought is hallelujah, it isn't a regression report.
Comment 5 Xisco Faulí 2021-07-20 09:31:06 UTC
This issue is fixed by https://git.libreoffice.org/core/commit/bda4d7a7c3fcc259e023f568606be5dcba818db9

Closing as duplicate of bug 123321

*** This bug has been marked as a duplicate of bug 123321 ***