Bug 127324 - Search-Function: Make comments searchable by default, if shown.
Summary: Search-Function: Make comments searchable by default, if shown.
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find-Search Writer-Comments
  Show dependency treegraph
 
Reported: 2019-09-04 03:22 UTC by DarkTrick
Modified: 2019-09-26 07:32 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DarkTrick 2019-09-04 03:22:18 UTC
Enhancement request regarding how the search function (Ctrl+F) behaves regarding comments.

Current Situation:
====================

- There is *no* "search in comments" option available inside the search menu bar, that opens with Ctrl+F

- There is a "search in comments" option inside the "search & replace dialog". 
Problem: It's too far from the Ctrl+F search bar.


- If a search is conducted including comments is entirely dependent on the setting made inside the "search & replace" dialog. 
Problem 1: If comments are shown and the option is set to "No", comments will not be searched. This might be unexpected to the user.
Problem 2: If comments are not shown and the option is set to "Yes", comments will be searched. However, as comments are not shown on screen the software seems to jump randomly within the document. This might be unexpected and confusing for the user.

related information: https://bugs.documentfoundation.org/show_bug.cgi?id=125974#c7


Enhancement Suggestion:
========================
1) Comments are always searched, if they are shown.
2.a) Comments are not searched, if they are not shown.  
  OR
2.b)Think of a solution on how to inform the user, that the search result is actually hidden at the moment.
3) If (1) and (2.a) are implemented: make "search in comments" option only apply to the search & replace function.
Comment 1 Dieter 2019-09-04 20:14:19 UTC
I support the proposal

cc: Design Team
Comment 2 Heiko Tietze 2019-09-05 12:13:04 UTC
According bug 125974 comment 7 (and above) it's the quick search bar that brings confusion. I'm somewhat split since we have many options in the dialog that won't be found with the quick search (ctrl+f). OTOH, it's obviously expected in that case. Opinions?
Comment 3 Heiko Tietze 2019-09-05 12:13:31 UTC Comment hidden (obsolete, spam)
Comment 4 DarkTrick 2019-09-05 18:11:52 UTC
(In reply to Heiko Tietze from comment #2)
> it's the quick search bar that brings confusion.
I would say a search result in a hidden comment also brings confusion.
Comment 5 Thomas Lendo 2019-09-22 20:53:20 UTC
I see a problem in moving the cursor to a hidden comment without any feedback. This should be enhanced. Maybe a text at the position of 'Reached the end of the document' with the alert 'Search result in a hidden comment' or something similar. Is it technically possible to see if a search result is in a hidden comment?

I don't like an automatism in the search dialog to include or not include the comments in a search action. What if a user wants the opposite? After reopening the dialog, the setting is reset -- or when should it be reset after a user change? Never? After program restart? Seems also confusing.

BTW I don't like the navigation commands in the search bar because they make the toolbar so long that the search help text isn't visible if the window isn't fullscreen.
Comment 6 Dieter 2019-09-23 05:48:44 UTC
(In reply to Thomas Lendo from comment #5)
> I see a problem in moving the cursor to a hidden comment without any
> feedback. This should be enhanced. Maybe a text at the position of 'Reached
> the end of the document' with the alert 'Search result in a hidden comment'
> or something similar. Is it technically possible to see if a search result
> is in a hidden comment?

I agree. But I also would expect, that searching within commments is activ, if comments are displayed.
 
> I don't like an automatism in the search dialog to include or not include
> the comments in a search action.

But we have this automatism actaually: Comments are not included.
Comment 7 Heiko Tietze 2019-09-23 07:46:17 UTC
For some reason, searching for comments cannot done for all - the button Find All becomes disabled (so perhaps there is a technical hurdle). I tend to WFM as comments or notes are more often excluded from a search.
Comment 8 Thomas Lendo 2019-09-24 19:11:21 UTC
I still prefer the first paragraph in my comment 5 to give the user a feedback if a search result is found in a hidden comment view.

But I neither would enhance the search bar as there's no place for it nor I would automatically activate and deactivate comment view.

Maybe a burger button is possible in the search bar where all search dialog settings can be activated/deactivated with toggle comments?
Comment 9 Cor Nouws 2019-09-24 19:49:41 UTC
(In reply to Dieter Praas from comment #6)
> I agree. But I also would expect, that searching within commments is activ,
> if comments are displayed.
Seems logic to me too.

OTOH for some options is Calc the choice is made that the search toolbar follows what has been last used in the search dialog.

How would that be?
Comment 10 Thomas Lendo 2019-09-24 20:14:14 UTC
(In reply to Cor Nouws from comment #9)
Bug 72080 comes into my mind and Bug 112270 - Find toolbar resets 'Other options' in the Find & Replace dialog.
Comment 11 Heiko Tietze 2019-09-26 06:31:02 UTC
Different opinions: keep it simple and have advanced search options only at the dialog vs. do always search in comments (ask for hidden comments when the end is reached).
Comment 12 DarkTrick 2019-09-26 07:32:55 UTC
(In reply to Heiko Tietze from comment #11)
> Different opinions: keep it simple and have advanced search options only at
> the dialog vs. do always search in comments (ask for hidden comments when
> the end is reached).

I also think too advanced options should be placed in the dialog. But please don't forget, that the dialog is found under "search & replace". For me, if I would not want to replace, I'd think that's not the right dialog. 

Maybe add an "advanced search" button within the search bar, that would then open the "search & replace" dialog ... ?