Download it now!
Bug 127357 - Mail merge's "Select address list" dialog is no longer modal (except on gtk3)
Summary: Mail merge's "Select address list" dialog is no longer modal (except on gtk3)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:6.4.0 target:6.3.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2019-09-05 08:55 UTC by Michael Weghorn
Modified: 2019-09-05 13:43 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2019-09-05 08:55:56 UTC
Steps to reproduce

0) use Windows or Linux with either the "gen" or the "kf5" VCL plugin
1) start LibreOffice Writer
2) start Mail Merge wizard ("Tools" -> "Mail Merge Wizard")
3) in step 3 of the wizard ("Insert Address book"), click the "Select Address List..." button

Result: 

* a "Select Address List" dialog opens, but it's not a modal dialog
* the "Select Address List..." button from the underlying "Mail Merge Wizard" dialog can be clicked again and a second "Select Address List" dialog opens
    * This can be repeated again and again to open even more of those dialogs

Expected behaviour:

* The dialog opening in step 3 should be modal, i.e. it shouldn't be possible to interact with the other wizard dialog until that one has been closed again.
* There should never be more than one "Select Address List" dialog at the same time

Notes:

* This works as expected when using the gtk3 VCL plugin on Linux instead (i.e. 'SAL_USE_VCLPLUGIN=gtk3')
Comment 1 Michael Weghorn 2019-09-05 09:01:20 UTC
Bibisected to this commit:

    commit 3963bab7c1cd31b946646131cdc5576894675293
    Author: Caolán McNamara <caolanm@redhat.com>
    Date:   Thu Feb 28 14:52:50 2019 +0000

        weld SwCreateAddressListDialog
        
        Change-Id: I3ae15af8a2c7475394dfc5f6e54b89950d2238c0
        Reviewed-on: https://gerrit.libreoffice.org/68511
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>



Fix pending at https://gerrit.libreoffice.org/#/c/78631/
Comment 2 Commit Notification 2019-09-05 12:23:59 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/111cf7ee0b26a831577c7c03089f9de159aef16d%5E%21

tdf#127357 Make "Select Address List" dialog modal again

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2019-09-05 13:43:28 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/81fe764c54b0f49ca91248abb1364e6aa0cd37dd%5E%21

tdf#127357 Make "Select Address List" dialog modal again

It will be available in 6.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.