Bug Hunting Session
Bug 127508 - I cannot disable effect from highlighted/normal column/row header
Summary: I cannot disable effect from highlighted/normal column/row header
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-11 22:36 UTC by Salem Yaslem
Modified: 2019-11-11 09:20 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Review headers (3.58 KB, image/jpeg)
2019-09-11 22:36 UTC, Salem Yaslem
Details
Before/After (10.78 KB, image/png)
2019-09-26 06:26 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Salem Yaslem 2019-09-11 22:36:03 UTC
Created attachment 154120 [details]
Review headers

I want disable that effect on highlighted column/row header, that give it gradient

But I cannot
Comment 1 Heiko Tietze 2019-09-19 12:33:29 UTC Comment hidden (obsolete)
Comment 2 Heiko Tietze 2019-09-19 12:39:49 UTC
How row/col headers are painted, meaning with or without gradient, depend on your system theme. But OTOH we made the tabbar for the sheets flat recently. So it's a good question to the design people.

AFAIR, there was a similar request recently but I cannot find the ticket. Anyone else?
Comment 3 Thomas Lendo 2019-09-24 19:26:49 UTC
Why should this effect be disabled? This is part of the UI like visualization of sheet tabs in Calc.
Comment 4 Salem Yaslem 2019-09-25 10:32:27 UTC
It's best to add a property to disable
I don't see it look beautiful
It's ugly
Comment 5 Heiko Tietze 2019-09-26 06:20:37 UTC
Submitted a patch and push it to master. It contains temporary changes, easy to revert, and I'd like to get more opinions on this topic. I don't want and option so we have to make a decision on flat or shaded headers. My take is flat.
Comment 6 Heiko Tietze 2019-09-26 06:26:27 UTC
Created attachment 154508 [details]
Before/After

Flat vs. Shaded
Comment 7 andreas_k 2019-09-26 06:27:16 UTC
Flat
Comment 8 Mike Kaganski 2019-09-26 06:37:51 UTC
(In reply to Heiko Tietze from comment #5)
> Submitted a patch and push it to master.

Could you please provide a link?
Comment 9 Heiko Tietze 2019-09-26 06:51:22 UTC
(In reply to Mike Kaganski from comment #8)
> Could you please provide a link?

https://gerrit.libreoffice.org/#/c/79584/
Comment 10 Commit Notification 2019-10-02 05:37:10 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/67fd62b3edc86c2891f279b25cf9919c4bbbbca1

Resolves tdf#127508 - Flat table header in Calc

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Cor Nouws 2019-10-02 09:42:34 UTC
(In reply to Heiko Tietze from comment #6)
> Created attachment 154508 [details]
> Before/After
> 
> Flat vs. Shaded
Where can I find the option? :)
Comment 12 Heiko Tietze 2019-10-02 09:51:33 UTC
Decided against an option. All flat now. Until we revert the patch ;-)
Comment 13 Xisco Faulí 2019-11-11 09:20:47 UTC
(In reply to Heiko Tietze from comment #12)
> Decided against an option. All flat now. Until we revert the patch ;-)

I like it flat more than shaded...