Bug 127976 - [Icon theme] Change Navigator's Update icon in Master document mode (Writer)
Summary: [Icon theme] Change Navigator's Update icon in Master document mode (Writer)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks: Icon-Theme-Breeze Icon-Theme-Colibre Icon-Theme-Elementary Icon-Theme-Sifr
  Show dependency treegraph
 
Reported: 2019-10-05 16:13 UTC by Roman Kuznetsov
Modified: 2019-11-26 13:15 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot with Sifr icon problem (42.18 KB, image/png)
2019-10-05 16:14 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2019-10-05 16:13:17 UTC
Description:
Change Navigator's Update icon in Master document mode (Writer)

Steps to Reproduce:
1. File->New->Master Document
2. Look at Navigator's Update icon (Sifr theme). Comparise it with Tools->Update menu item's icon

Actual Results:
Wrong icon for Update function in Master Document's Navigator

Expected Results:
Good icon for Update function in Master Document's Navigator like for Tools->Update menu item


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha0+
Build ID: 8387a6db641b29e6ff3c2f4cdc4688f538cbe35f
CPU threads: 4; OS: Linux 5.2; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-08-09_06:28:42
Locale: ru-RU (ru_RU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Roman Kuznetsov 2019-10-05 16:14:00 UTC
Created attachment 154769 [details]
Screenshot with Sifr icon problem
Comment 2 Heiko Tietze 2019-10-16 10:19:47 UTC
Andreas, Rizmut: What do you think?
Comment 3 Rizal Muttaqin 2019-10-16 16:03:22 UTC
Seems this issue affected to all icon themes except Karasa Jaga since KJ is always trying to follow Galaxy
Comment 4 Heiko Tietze 2019-10-17 08:11:57 UTC
So let's fix it.
Comment 5 Rizal Muttaqin 2019-10-17 10:15:10 UTC
(In reply to Heiko Tietze from comment #4)
> So let's fix it.

elementary's fix is coming: https://gerrit.libreoffice.org/#/c/80936/
Comment 6 Commit Notification 2019-10-18 06:42:38 UTC
rizmut committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0b24dcca00333405203c5cb3d1a92a81b346930d

elementary: tdf#127976 fix navigators icons in Writer master doc mode"

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2019-10-20 13:48:33 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3ca1f32df446f2d1989f95cbb43163d961b29a1e

 tdf#127976, tdf#127977: Fix for navigator icons

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Roman Kuznetsov 2019-10-23 21:22:39 UTC
verified in

Версия: 6.4.0.0.alpha1+
ID сборки: 475165e431b5392e426db0de4cea50efc2513875
Потоков ЦП: 4; ОС:Linux 5.2; Отрисовка ИП: по умолчанию; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2019-10-22_04:14:35
Локаль: ru-RU (ru_RU.UTF-8); UI-Language: ru-RU
Calc: threaded

Rizal, thank you
Comment 9 Rizal Muttaqin 2019-10-24 00:07:07 UTC
I reopen this bug because it affects other themes including Breeze and Colibre which are left behind.
Comment 10 Commit Notification 2019-10-26 10:04:18 UTC
rizmut committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f957a4a30d6a9ff4c1c33dcfc078c1145f5685b7

 Breeze: tdf#127976, Fix icons in Navigator Writer master document mode

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Roman Kuznetsov 2019-10-26 11:15:46 UTC
(In reply to Rizal Muttaqin from comment #9)
> I reopen this bug because it affects other themes including Breeze and
> Colibre which are left behind.

So, is it fixed now? =)
Comment 12 Rizal Muttaqin 2019-10-26 15:10:57 UTC
(In reply to Roman Kuznetsov from comment #11)
> (In reply to Rizal Muttaqin from comment #9)
> > I reopen this bug because it affects other themes including Breeze and
> > Colibre which are left behind.
> 
> So, is it fixed now? =)

Wait for the last: Colibre
Comment 13 Commit Notification 2019-10-26 21:31:11 UTC
rizmut committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e5874d6a72629ae298c97172f3c06137ed3dcab0

Colibre: tdf#127976, Fix icons in Navigator Writer master document mode

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Xisco Faulí 2019-11-26 10:10:23 UTC
A polite ping to rizmut:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing?
Thanks