Bug 128251 - EPUB Export dialog’s labels are not consistently aligned
Summary: EPUB Export dialog’s labels are not consistently aligned
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: low minor
Assignee: andreas_k
URL:
Whiteboard: target:6.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-19 11:58 UTC by andreas_k
Modified: 2019-10-26 08:13 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Epub master (40.11 KB, image/png)
2019-10-19 11:58 UTC, andreas_k
Details
Epub 01 (36.98 KB, image/png)
2019-10-19 11:59 UTC, andreas_k
Details
Epub 02 (28.34 KB, image/png)
2019-10-22 06:43 UTC, andreas_k
Details
Epub 03 (38.41 KB, image/png)
2019-10-23 21:30 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2019-10-19 11:58:06 UTC
Created attachment 155149 [details]
Epub master

As you can see there is a mix between label on top and left. From my point of view the UI is non consistent.
Comment 1 andreas_k 2019-10-19 11:59:23 UTC
Created attachment 155150 [details]
Epub 01

The proposal. All Labels are left align.

As the .ui file is full of special paddings, an update will also remove this hardcoded elements.
Comment 2 Adolfo Jayme Barrientos 2019-10-22 06:23:47 UTC
Rather update all labels to be on top of their controls, not to their left. Now the dialog takes too much horizontal space; it’s not harmonious (height to width ratio) and it gets worse when using a non-English UI.
Comment 3 andreas_k 2019-10-22 06:27:32 UTC
thanks for the feedback.

I don't have an issue with top or left, but when the label arrangement is mixed, than from my point of view it's very unbalanced.

In general left labels are easier to read
Comment 4 andreas_k 2019-10-22 06:43:05 UTC
Created attachment 155225 [details]
Epub 02

and when we arrange the groups vertical? And the long labels have there own row.

In general I would be an big fan of short labels + an description if needed.
Comment 5 Heiko Tietze 2019-10-22 12:06:12 UTC
#2 looks better except the Custom part. How about another section "Custom option" and shorter labels "Cover image", "Media directory" but left of the input?
Comment 6 andreas_k 2019-10-23 21:30:25 UTC
Created attachment 155268 [details]
Epub 03

I like it good idea Heiko.
Comment 7 Heiko Tietze 2019-10-24 09:52:08 UTC
Go for it.
Comment 8 Commit Notification 2019-10-25 06:50:59 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2c79de0a12a9568a3feda2592de1edc6c6b29207

tdf#128251 EPUB Export Dialog update

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Cor Nouws 2019-10-26 08:13:28 UTC
nice - thanks Andreas!