Bug 128550 - [FILEOPEN PPTX] list item appear animation
Summary: [FILEOPEN PPTX] list item appear animation
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0 target:7.1.1 target:7.0.5
Keywords: bibisected, bisected, filter:pptx, regression
Depends on:
Blocks: PPTX Object-Animations
  Show dependency treegraph
 
Reported: 2019-11-02 13:36 UTC by Pablo
Modified: 2021-06-10 12:21 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
PPTX with bullet list appear animation (29.52 KB, application/zip)
2019-11-02 13:36 UTC, Pablo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo 2019-11-02 13:36:22 UTC
Description:
The attached PPTX exported from Keynote for iCloud has a bullet list with appear animation on the second slide. Each item should appear on a separate click but in Impress they all appear at once.

Steps to Reproduce:
1. Open the attached PPTX and play the animation in the second slide.
2. Compare with PowerPoint.

Actual Results:
All list items appear at once on a single click.

Expected Results:
Each list item should appear on a separate click.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.0.0.alpha1
Build ID: cc57df8f942f239d29cb575ea5a7cb01405db787
CPU threads: 1; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: en-US (en_IL); UI-Language: en-US
Calc: threaded
Comment 1 Pablo 2019-11-02 13:36:54 UTC
Created attachment 155465 [details]
PPTX with bullet list appear animation
Comment 2 Pablo 2019-11-03 13:29:45 UTC
Making the following change to the first animation make each item show with a separate click like in PowerPoint instead of all at once.
The original file works in PowerPoint so it shouldn't be required.

ppt/slides/slide2.xml
---<p:tgtEl>
---  <p:spTgt spid="123">
---    <p:bg/>
---  </p:spTgt>
---</p:tgtEl>

+++<p:tgtEl>
+++  <p:spTgt spid="123">
+++    <p:txEl>
+++      <p:pRg st="0" end="0"/>
+++    </p:txEl>
+++  </p:spTgt>
+++</p:tgtEl>
Comment 3 Xisco Faulí 2019-11-04 11:29:29 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=a472d3352a61b51624aea480410789e3f547a9ca

author	Mark Hung <marklh9@gmail.com>	2018-08-03 23:59:54 +0800
committer	Mark Hung <marklh9@gmail.com>	2018-08-06 15:15:30 +0200
commit a472d3352a61b51624aea480410789e3f547a9ca (patch)
tree 0dce2c14ba914d0422e2a61f4b0e726c48d181cb
parent df1d4bd528027c60bcab2f2e0a87303610fad326 (diff)
tdf#113822 handle letter-by-letter animations in pptx documents.

Bisected with: bibisect-linux64-6.2

Adding Cc: to Mark Hung
Comment 4 Jack 2021-01-14 16:10:56 UTC
Confirmed this is still occurring on the latest version of Libreoffice (7.0.4)
Comment 5 Commit Notification 2021-01-20 11:15:07 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9b19bf0283b569a5c134de6b5cce1d72d8f37879

tdf#128550 set sub item on the ancestor node.

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-01-21 09:36:36 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/742b699335ca81626e79c937389efd6b5fdc15ed

tdf#128550 set sub item on the ancestor node.

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2021-01-21 10:10:50 UTC
Verified in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: bd6214e2aa6f25e013eef769529b75c1e3b580cb
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Mark Hung, thanks for fixing this issue!! Should it be closed as RESOLVED FIXED ??
Comment 8 Commit Notification 2021-01-21 14:31:17 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/d56e4aea5fd5d777204f9f4e4b14cf0047348beb

tdf#128550 set sub item on the ancestor node.

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.