Bug 128775 - EDITING Hyperlink on accented filename has bad character encoding
Summary: EDITING Hyperlink on accented filename has bad character encoding
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: medium normal
Assignee: Tünde Tóth
URL:
Whiteboard: target:6.5.0 target:6.4.0.1
Keywords:
Depends on:
Blocks: DOCX-Hyperlink
  Show dependency treegraph
 
Reported: 2019-11-13 11:45 UTC by NISZ LibreOffice Team
Modified: 2019-11-22 07:58 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the problem in Writer (71.56 KB, image/png)
2019-11-13 11:47 UTC, NISZ LibreOffice Team
Details
The original file saved by Writer (9.61 KB, application/binary)
2019-11-13 11:47 UTC, NISZ LibreOffice Team
Details
The file for Hyperlink Target (8.47 KB, application/binary)
2019-11-13 11:47 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-11-13 11:45:56 UTC
Description:
Hyperlink on accented filename in LinreOffice Writer has bad character encoding when the Target is Bookmark.

Steps to Reproduce:
    1. Create a document with name áéíóöőúüű.odt in a local folder.
    2. Insert a Bookmark.
    3. Create a new document in LibreOffice Writer.
    4. Insert Hyperlink to the document áéíóöőúüű.odt.
    5. Choose the Bookmark as Target in Document.
    6. Apply the changes.
    7. View the attached screenshot.
    8. Notice, that the file name changes to /%C3%A1%C3%A9%C3%AD%C3%B3%C3%B6%C5%91%C3%BA%C3%BC%C5%B1.odt

Actual Results:
Hyperlink has bad character encoding.

Expected Results:
Hyperlink should keep the original character encoding.


Reproducible: Always


User Profile Reset: No



Additional Info:
LibreOffice details:
Version: 6.4.0.0.alpha1+ (x86)
Build ID: 80109586e6cb6d3e2e0a53a9079c3125ec9b8368
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL
Comment 1 NISZ LibreOffice Team 2019-11-13 11:47:00 UTC
Created attachment 155780 [details]
Screenshot of the problem in Writer
Comment 2 NISZ LibreOffice Team 2019-11-13 11:47:33 UTC
Created attachment 155782 [details]
The original file saved by Writer
Comment 3 NISZ LibreOffice Team 2019-11-13 11:47:57 UTC
Created attachment 155783 [details]
The file for Hyperlink Target
Comment 4 Tünde Tóth 2019-11-14 10:59:33 UTC
Reproduced in:
Version: 6.4.0.0.alpha1+ (x64)
Build ID: ad0a97ca200328d336a3cd58942f71a824b1f23a
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: threaded

and:
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735
Comment 5 Commit Notification 2019-11-21 17:06:27 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/79a1fafadb1ac54b8212bc164d8b85d798c74937

tdf#128775 Writer Hyperlink dialog: fix encoding of inserted target URL 

It will be available in 6.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2019-11-21 19:57:42 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/8805379ca0fd8cbdfd032f54200a8fa3d52b1ec7

tdf#128775 Writer Hyperlink dialog: fix encoding of inserted target URL 

It will be available in 6.4.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.