Description: When displaying preview images within Startcenter, previews for encrypted files are garbled (see screenshot attached). Issue is independent of application (Writer, Calc etc.) and exists on Linux and macOS at least. Steps to Reproduce: 1. Open any LibreOffice application (e.g. Writer) 2. Save a document encrypted with password 3. Open Startcenter and select "Recent Files" Actual Results: Previews of encrypted documents are garbled. Expected Results: Previews of encrypted documents appear without garbage. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Issue exists with and without Open GL enabled.
Created attachment 156928 [details] Screenshot
I can't reproduce it in Version: 6.5.0.0.alpha0+ Build ID: 838935758a5ec8e0e68f4df0cf5bfcf737e3f6f2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded nor in Version: 6.5.0.0.alpha0+ Build ID: 838935758a5ec8e0e68f4df0cf5bfcf737e3f6f2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded Could you please paste the info from Help - about LibreOffice ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the information has been provided
Infos from Help / About are as follows: (1) Linux Version: 6.5.0.0.alpha0+ Build ID: fc93925a935960c750f400b9b3c79a592baaf5fe CPU threads: 6; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded (2) macOS Version: 6.5.0.0.alpha0+ Build ID: fc93925a935960c750f400b9b3c79a592baaf5fe CPU threads: 12; OS: Mac OS X 10.14.6; UI render: default; VCL: osx; Locale: de-DE (en_US.UTF-8); UI-Language: en-US Calc: threaded Issue still exists with current master.
To me this looks like a reverse request from bug 80755, that cannot be accepted, so I mark NotABug. If it's not, please explain and set Unconfirmed.
Created attachment 157076 [details] Screenshot from an earlier LO release
#tdf80755 deals with cached preview images of password protected files. This is not the issue here. Screenshot attached shows pixelated image fragments behind the icon. Please find another screenshot of an earlier LO release attached. Behaviour was as expected there: no preview, no pixelated image fragments behind the icon.
OK. I see now. Regression.
Bisected to: author Noel Grandin <noel.grandin@collabora.co.uk> 2019-07-08 14:50:12 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2019-07-08 21:29:01 +0200 commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137 (patch) tree 7c8e8305622db175afc115dffae92d9df1192f28 parent 9e8c6c81f2f5d3df850353ee92a5b6e52546d6c6 (diff) no need to use AlphaMask in RecentDocsViewItem since it's purely opaque https://cgit.freedesktop.org/libreoffice/core/commit/?id=31bd8c4a4a4752dcff12ee35636193f79a6d6137
Adding CC to: Noel Grandin
This is similar to bug 129143 @Noel, should we just revert commit 31bd8c4a4a4752dcff12ee35636193f79a6d6137 as we did for bug 129143 ??
Xisco Faulí committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/be638ffb1ed82530162d18784e31c3506575ad7b tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem" It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/d720e120b6534ff2fdf6cb11f0b46eca454d4e34 tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem" It will be available in 6.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-4-0": https://git.libreoffice.org/core/commit/0768fa976bd44f6a9c96720dcc1a0272c0364e8b tdf#129788: Revert "no need to use AlphaMask in RecentDocsViewItem" It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Issue is fixed on macOS but a similar issue is visble on Linux now (see latest screenshot attached). Screenshot was taken from current revision from master: Version: 7.0.0.0.alpha0+ Build ID: 796aeeb0f4c26824f3477b45e0d3bae9cf2c4648 CPU threads: 6; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
Created attachment 158063 [details] Screenshot using Linux/GTK
Created attachment 177271 [details] Bug is not reproducible Version: 7.2.3.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Ubuntu package version: 1:7.2.3~rc2-0ubuntu0.20.04.1~lo1 Calc: threaded
Confirming that issue seems to have disappeared with current revisions of LO (at least with LO 7.2.4 and later, retested on macOS and on UNIX using GTK).