Bug 130013 - XHP Editor rendering (or checking) modifies .xhp source files - & are replaced by '&'
Summary: XHP Editor rendering (or checking) modifies .xhp source files - & are rep...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.5.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-15 11:25 UTC by LibreOfficiant
Modified: 2020-10-28 16:53 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description LibreOfficiant 2020-01-15 11:25:15 UTC
Description:
& are replaced by '&' - cf. ' &h &o literal notations ' patch file for example

https://gerrit.libreoffice.org/c/help/+/85590

Steps to Reproduce:
1. Paste patch#85590 .xhp file in the editor
2. Render XHP, display is fine
3. Check XHP, modified lines are caught

Actual Results:
Initial rendering works fine
Subsequent attempts fail

Expected Results:
Rendering or checking modify XHP file content


Reproducible: Always


User Profile Reset: No



Additional Info:
XHP file should not be modified

Previous XHP Editor version does not modifiy XHPs
Comment 1 Olivier Hallot 2020-01-15 13:14:54 UTC
ok. Need to find a way to escape & in textarea.
Comment 2 Commit Notification 2020-01-15 14:48:56 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/contrib/dev-tools/commit/0d1b7db3fcc4ea9f52131ef943ab445770ce6df8

tdf#130013 Prevent entities to be converted in textarea
Comment 3 Alain Romedenne 2020-10-28 16:53:45 UTC
tested ok