Download it now!
Bug 130137 - Replace remaining uses of WNT define checks with _WIN32
Summary: Replace remaining uses of WNT define checks with _WIN32
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
(earliest affected)
Hardware: All All
: medium normal
Assignee: ahmad_g
Whiteboard: target:6.5.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Reported: 2020-01-23 10:24 UTC by Mike Kaganski
Modified: 2020-03-06 19:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2020-01-23 10:24:14 UTC

Here are available some instances of precompiler checks like

> #elif defined WNT

We already had some cleanups replacing checks for windows to uniform _WIN32 - see

But these in the opengrok list are likely leftovers from those commits. The easy hack is to clean up them to use consistent check for _WIN32.
Comment 1 Commit Notification 2020-01-25 21:03:06 UTC
A_GAN committed a patch related to this issue.
It has been pushed to "master":

tdf#130137 Replace remaining uses of WNT define checks with _WIN32

It will be available in 6.5.0.

The patch should be included in the daily builds available at in the next 24-48 hours. More
information about daily builds can be found at:

Affected users are encouraged to test the fix and report feedback.