Created attachment 157411 [details] sample file Steps to reproduce: 1. Open attached document 2. Click on the picture 3. Insert - Comment -> Crash Reproduced in Version: 7.0.0.0.alpha0+ Build ID: 6b4fe3e44b4daa89fef6a3385919b00472eaed60 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b382025abcd05ff75dd2cbe46df76213d4913f00 author Miklos Vajna <vmiklos@collabora.com> 2019-07-04 17:40:09 +0200 committer Miklos Vajna <vmiklos@collabora.com> 2019-07-04 18:22:06 +0200 commit b382025abcd05ff75dd2cbe46df76213d4913f00 (patch) tree 792ea8a0298faaf531379b5793af5f98a52c459c parent 9a4980c3b16a8068d6ebba8377d2c5c0cb4b2367 (diff) sw comments on frames: fix comment insert for as-char frame at para start Bisected with: bibisect-linux64-6.4 Adding Cc: to Miklos Vajna
Created attachment 157415 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today, I got an assertion
With LO Debian package 6.3.4, I can't reproduce this because "Insert comment" is disabled when clicking on the picture.
I can reproduce with Version: 7.0.0.0.alpha0+ Build ID: d52384260c4a8f096945b33b89430398ffa69431 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3; Locale: nl-BE (en_US.UTF-8); UI-Language: en-US Calc: threaded
(In reply to Julien Nabet from comment #3) > With LO Debian package 6.3.4, I can't reproduce this because "Insert > comment" is disabled when clicking on the picture. Yes, it's a new feature introduced with LO 6.4.
I'll take a look. The image commenting is meant to work only with as-char/at-char images, the UI should be disabled for the at-para case.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d05a65bec5dc498f66f9331189124d539bc0d505 tdf#130179 sw comments on frames: limit insert UI for at-char and ... It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I do confirm the issue is fixed in Version: 7.0.0.0.alpha0+ Build ID: aef7feb3e695ecf6d411f0777196dcc4281e201a CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded as adding comment is disabled. @Miklos, thanks for fixing this issue!
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/e9d223580d25215ab6e76abcc2b77ce145fcc6b1 tdf#130179 sw comments on frames: limit insert UI for at-char and ... It will be available in 6.4.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.