Bug 130223 - Formula bar not shown on tablets (+misaligned row headers)
Summary: Formula bar not shown on tablets (+misaligned row headers)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Aron Budea
URL:
Whiteboard: target:6.5.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-01-27 13:26 UTC by Aron Budea
Modified: 2020-01-28 17:47 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot from an iPad (203.71 KB, image/png)
2020-01-27 13:26 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2020-01-27 13:26:53 UTC
Created attachment 157454 [details]
Screenshot from an iPad

This can be reproduced both on an iPad and an Android tablet, and also in Chrome's responsive design mode (with eg. dimensions set to 768x1024).

- Open a spreadsheet on a tablet.
- Switch to edit mode.

=> No formula bar appears, the top rows are covered by the toolbar, and the row headers are also misaligned (see attached screenshot, the selected cell is in row 5).

This is a regression, bisected to the following commit. Adding CC: to Samuel Mehrbrodt, please take a look.

https://cgit.freedesktop.org/libreoffice/online/commit/?id=2f861612e9aac7e92722597f345a6ab4f4e00d02
author		Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-05-23 15:38:45 +0200
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-05-23 16:23:18 +0200

"Some menubar folding/unfolding cleanups"
Comment 1 Aron Budea 2020-01-27 17:18:11 UTC
Samuel, do you think you will be able to look into this issue in the foreseeable future? If not, would reverting the commit be an option for the time being?
Comment 2 Samuel Mehrbrodt (allotropia) 2020-01-27 20:18:34 UTC
(In reply to Aron Budea from comment #1)
> Samuel, do you think you will be able to look into this issue in the
> foreseeable future? If not, would reverting the commit be an option for the
> time being?

Ah that was just a cosmetic fix, feel free to revert it :)
Comment 3 Commit Notification 2020-01-28 17:45:11 UTC
Aron Budea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/db2ae7432ddc432e42811bb125bd0d5a39a4087e

tdf#130223: Revert "Some menubar folding/unfolding cleanups"
Comment 4 Aron Budea 2020-01-28 17:47:11 UTC
Thanks for the reply, Samuel, reverted now. Let's close as FIXED.