Bug 130228 - List Styles icon in Formatting Styles toolbar shows Paragraph Styles
Summary: List Styles icon in Formatting Styles toolbar shows Paragraph Styles
Status: RESOLVED DUPLICATE of bug 107000
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Toolbar-Formatting-Styles
  Show dependency treegraph
 
Reported: 2020-01-27 15:31 UTC by sdc.blanco
Modified: 2020-02-04 19:32 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-01-27 15:31:25 UTC
1. View - Toolbars - Formatting (Styles) (check)
2. Tools - Customize - Toolbars tab - (target) Formatting (Styles) - List Styles (make sure it is checked)
3. In Formatting (Styles) menubar, click on drop-down box for icon that corresponds to "List styles".

Actual results:  (a) Tooltip: Set Paragraph Style (b) drop-down box shows Paragraph Styles

Expected Result:  List Styles

4.  Search in Tools- Customize- Toolbars bar with "Style"

Actual Result:  List Styles does not appear.

Tested with LO 6.3.4.2 and 7.0.0.0.alpha
Comment 1 Dieter 2020-01-27 18:05:23 UTC
I confirm it with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: eeb2d19e77d6dc47c68e8ba0920a02cf64a1247b
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded
Comment 2 Xisco Faulí 2020-01-28 16:04:50 UTC
Also reproduced in

Version: 6.1.0.0.alpha1+
Build ID: 3a801799536e6870f2fb111b1cc00b9575a35a39
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); Calc: group
Comment 3 Heiko Tietze 2020-01-30 15:51:07 UTC
Rizal, Andreas: one for you.
Comment 4 Rizal Muttaqin 2020-01-31 09:58:05 UTC
Reproducible

Version: 7.0.0.0.alpha0+
Build ID: 4ff12ba6f4639c73587f2bb58afcc3ca6fb30105
CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-01-24_21:09:14
Locale: id-ID (id_ID.UTF-8); UI-Language: en-US
Calc: threaded

Aside to Heiko
(In reply to Heiko Tietze from comment #3)
> Rizal, Andreas: one for you.

Which one? I think this is related to code, not merely icon design.
Comment 5 Julien Nabet 2020-01-31 21:34:10 UTC
On pc Debian x86-64 with master sources updated today + gtk3 rendering, after having enabled "List styles", the icon doesn't appear on formatting styles toolbar.
Comment 6 Maxim Monastirsky 2020-02-04 15:22:51 UTC
List styles command was never implemented (Bug 107000), and the current "Formatting (Styles)" toolbar seems to be just a prototype, showing how such toolbar should look like. So it has paragraph styles item as a placeholder for a future list styles control. Same thing for character styles (Bug 130260).

The toolbar xml has clear comments, indicating that it isn't supposed to work for character/list styles in its current state:

https://cgit.freedesktop.org/libreoffice/core/tree/sw/uiconfig/swriter/toolbar/textstylebar.xml#n47

https://cgit.freedesktop.org/libreoffice/core/tree/sw/uiconfig/swriter/toolbar/textstylebar.xml#n73

*** This bug has been marked as a duplicate of bug 107000 ***
Comment 7 Heiko Tietze 2020-02-04 15:26:17 UTC
(In reply to Maxim Monastirsky from comment #6)
> List styles command was never implemented (Bug 107000)...

Thanks for clarification. Do you think we should set visibility to false, as it likely was done in the first place.
Comment 8 Maxim Monastirsky 2020-02-04 15:38:54 UTC
(In reply to Heiko Tietze from comment #7)
> Do you think we should set visibility to false
Visibility is false, but it still listed in the customization dialog as unchecked, and users getting there might try to enable it. If we consider this as a problem, we'll have to remove these command completely from the toolbar xml for now.
Comment 9 Thomas Lendo 2020-02-04 19:12:37 UTC
Hm, yeah, the idea from Jay and me of these items was to have placeholders to not forget these commands as part of this style formatting toolbar. Removing them completely brings the risk to forget them in the future (as they are forgotten now in the Customize dialog).
Comment 10 Julien Nabet 2020-02-04 19:32:00 UTC
(In reply to Thomas Lendo from comment #9)
> Hm, yeah, the idea from Jay and me of these items was to have placeholders
> to not forget these commands as part of this style formatting toolbar.
> Removing them completely brings the risk to forget them in the future (as
> they are forgotten now in the Customize dialog).

git log --follow -S 'These command can be enabled when' sw/uiconfig/swriter/toolbar/textstylebar.xml
commit e3cfb753524ecfabc07bccef5f5b2b54d06cd444
Author: Yousuf Philips <philipz85@hotmail.com>
Date:   Thu Apr 20 17:01:10 2017 +0400

    tdf#106781 Style-focused formatting toolbar for writer

It's been disabled since more than 2 years.
So 3 questions:
1) Is it really useful?
2) Does someone want to do the job ?
If yes:
3) in what delay?
I mean, it's a problem for the moment since some people submit bugs about it (and I can understand).
This part could be removed temporarily (more precisely until someone finishes the job), it wouldn't be lost since it'll be in git history.